fix(Nav): updated var placement for nav flyout menus#6435
Merged
mcoker merged 2 commits intopatternfly:v6from Mar 19, 2024
Merged
fix(Nav): updated var placement for nav flyout menus#6435mcoker merged 2 commits intopatternfly:v6from
mcoker merged 2 commits intopatternfly:v6from
Conversation
Collaborator
|
Preview: https://patternfly-pr-6435.surge.sh A11y report: https://patternfly-pr-6435-a11y.surge.sh |
thatblindgeye
commented
Mar 19, 2024
| flex-grow: 1; | ||
| } | ||
|
|
||
| + .#{$menu} { |
Contributor
Author
There was a problem hiding this comment.
This is due to how the markup is setup in Core - a nav with a menu sibling. In React, though, the menu is a descendant of nav.
If the React markup is the correct one, I can update the nav flyout example in core to match and update this to remove this sibling combinator and just target any menu decendant of nav.
Contributor
Author
There was a problem hiding this comment.
Updated to nsst the menu inside nav per off-GH discussion
Collaborator
|
🎉 This PR is included in version 6.0.0-alpha.102 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #6327