fix(page): add container around main element#6410
Conversation
|
Preview: https://patternfly-pr-6410.surge.sh A11y report: https://patternfly-pr-6410-a11y.surge.sh |
| This is a default <code>.pf-v6-c-page__main-section</code>. | ||
| {{/page-main-section}} | ||
| {{/page-main}} | ||
| {{#> page-main-container}} |
There was a problem hiding this comment.
Looks like this is only in one page component example. Could you just wrap the contents of page-main.hbs in {{#> page-main-container}} ... {{/page-main-container}}? If so I think you could also remove it from here
patternfly/src/patternfly/demos/Page/page-template-main.hbs
Lines 1 to 5 in a63aaa8
There was a problem hiding this comment.
One more bit - now that {{#> page-main}} includes this globally, we can remove the container from this template
patternfly/src/patternfly/demos/Page/page-template-main.hbs
Lines 1 to 5 in 6ffe50d
Also just to confirm, with a drawer in the page (like a notification drawer) the grid area for the main page stuff is .pf-c-page__drawer which is not currently wrapped in the main-container - should it be, or is it good the way it is?
if one is good, two are better, no? 🤪
Hmmmmm. That would fix a problem where a drawer content with a background escapes the rounded corners, but also cause the drawer panel to be contained inside the rounded corners, which is not the intention I think. |
|
🎉 This PR is included in version 6.0.0-alpha.104 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This adds a container around the main element so that the border-rounding and other styling can be applied to the container, while the main element handles layout of the sections.
Fixes #6225