8000 chore(table): added partials for interactive elements by mattnolting · Pull Request #6403 · patternfly/patternfly · GitHub
[go: up one dir, main page]

Skip to content

chore(table): added partials for interactive elements#6403

Merged
mcoker merged 1 commit intopatternfly:v6from
mattnolting:chore-table-interactive-cells
Mar 8, 2024
Merged

chore(table): added partials for interactive elements#6403
mcoker merged 1 commit intopatternfly:v6from
mattnolting:chore-table-interactive-cells

Conversation

@mattnolting
Copy link
Collaborator

supports #10057
supports #6272
refers to #6324
refers to #6293

@patternfly-build
Copy link
Collaborator
patternfly-build commented Mar 7, 2024

@mattnolting mattnolting force-pushed the chore-table-interactive-cells branch 3 times, most recently from 5eb1832 to ec5c216 Compare March 7, 2024 22:00
@mattnolting mattnolting requested a review from mcoker March 7, 2024 22:00
@mcoker
Copy link
Contributor
mcoker commented Mar 8, 2024

Here is the visual regression test - BackstopJS Report.pdf

Copy link
Contributor
@mcoker mcoker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - just needs a rebase. Feel free to go ahead and rebase & merge if there are no other updates needed.

@mcoker mcoker force-pushed the chore-table-interactive-cells branch from ec5c216 to eaa9aa0 Compare March 8, 2024 01:39
@mcoker mcoker merged commit f42a874 into patternfly:v6 Mar 8, 2024
@patternfly-build
Copy link
Collaborator

🎉 This PR is included in version 6.0.0-alpha.99 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

0