chore(table): color and padding updates#6401
Conversation
|
Preview: https://patternfly-pr-6401.surge.sh A11y report: https://patternfly-pr-6401-a11y.surge.sh |
|
@mattnolting I'm seeing things I don't expect, but maybe somethings aren't implemented yet and in some cases I'm not sure what the design is saying.
- Sticky columns seem to have come unstuck (I don't remember seeing if they were working in previous PRs)
- In compound expansion in dark mode, the "tab" and the content area are different colors
|
@srambach Thanks for the review!
@srambach Not sure about this. I'll defer to design, but this is the default presentation. We need design to advise this use case and would create a followup for that if needed. @lboehling @andrew-ronaldson
@srambach The caret needs to be updated. That's coming in the next issue.
@srambach The caret needs to be updated. That's coming in the next issue.
@srambach This is valid, nice catch! I'll update the color
@srambach Sticky columns aren't sticky because of a workspace update. That will be 2 PRs from now, coming today :) |
|
thanks matt! regarding the gray bkg -- that should only show on clickable rows. Regular expandable rows would present the same as in v5 And clickable rows would get the gray bkg (with the expanded content presenting on a white bkg) apologies for any confusion on the designs! |
fe11c35 to
75e61db
Compare
There was a problem hiding this comment.
< 8000 /div>LGTM, a few comments but nothing is blocking.
|
Should the borderless expandable table have any borders? |
|
Also, the expansion tab thingie and background color of the contents seem to be different in dark mode, and I can't tell whether it is in Figma or not. |
95ed65e to
5504d26
Compare
@srambach I don't believe so, nice catch!
@srambach The compound expansion button appears to be using the correct token ( 
@lboehling @andrew-ronaldson WDYT>? |
|
🎉 This PR is included in version 6.0.0-alpha.101 🎉 The release is available on: Your semantic-release bot 📦🚀 |
relates to #5728
Remaining known issues
#6293