fix(utilities): rtl, penta updates#6400
Merged
mcoker merged 2 commits intopatternfly:v6from Mar 18, 2024
Merged
Conversation
Collaborator
|
Preview: https://patternfly-pr-6400.surge.sh A11y report: https://patternfly-pr-6400-a11y.surge.sh |
srambach
approved these changes
Mar 18, 2024
Member
There was a problem hiding this comment.
Looks good 👍 Thanks for doing this one.
Collaborator
|
🎉 This PR is included in version 6.0.0-alpha.101 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #6273 and drops in a few other easy penta changes
@srambach updates the utility syntax so they're using logical properties and all of the examples work. Renames the local sass objects in the utilities from v5 -> v6, but leaves the global sass mixins and functions with v5 in the name since that's a larger effort (isn't limited to just utilities).
Lemme know if this is too big of a PR or if it conflicts with anything you wanted to work on in the utility updates!