8000 chore(table): remove shadows by mattnolting · Pull Request #6375 · patternfly/patternfly · GitHub
[go: up one dir, main page]

Skip to content

chore(table): remove shadows#6375

Merged
mcoker merged 3 commits intopatternfly:v6from
mattnolting:chore-table-remove-box-shadows
Mar 4, 2024
Merged

chore(table): remove shadows#6375
mcoker merged 3 commits intopatternfly:v6from
mattnolting:chore-table-remove-box-shadows

Conversation

@mattnolting
Copy link
Collaborator

references #5728

@patternfly-build
Copy link
Collaborator
patternfly-build commented Mar 1, 2024

@mattnolting mattnolting marked this pull request as draft March 1, 2024 16:24
@mattnolting mattnolting marked this pull request as ready for review March 1, 2024 16:41
@mattnolting mattnolting force-pushed the chore-table-remove-box-shadows branch from 601b01c to 4232fca Compare March 4, 2024 15:09
Copy link
Member
@srambach srambach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 this does remove all box shadows. I'd guess you'll want some of the removed selectors back for the hover states' background colors but if so they're always in history I guess.

Copy link
Contributor
@mcoker mcoker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@mcoker mcoker merged commit 8d0d0c3 into patternfly:v6 Mar 4, 2024
@patternfly-build
Copy link
Collaborator

🎉 This PR is included in version 6.0.0-alpha.99 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

0