Merged
Conversation
b096edf to
c518d64
Compare
Collaborator
|
Preview: https://patternfly-pr-6374.surge.sh A11y report: https://patternfly-pr-6374-a11y.surge.sh |
9b9575f to
4111ddc
Compare
4111ddc to
e3c97ca
Compare
e3c97ca to
c8b370f
Compare
srambach
reviewed
Mar 1, 2024
Member
There was a problem hiding this comment.
Pending all the discussion about buttons and alignment... just didn't know if box shadows should be removed in this PR..I don't think Figma shows any, unless I'm missing it.
Comment on lines
+686
to
+689
| &:is(:hover, :focus) { | ||
| --#{$table}__tbody--m-clickable--BoxShadow: var(--#{$table}__tbody--m-clickable--hover--BoxShadow); | ||
| --#{$table}__tbody--m-clickable--BackgroundColor: var(--#{$table}__tbody--m-clickable--hover--BackgroundColor); | ||
|
|
Member
There was a problem hiding this comment.
If I'm not mistaken - can't all the BoxShadows be removed?
srambach
approved these changes
Mar 1, 2024
Collaborator
|
🎉 This PR is included in version 6.0.0-alpha.99 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
references: #5728