fix(menu-toggle): dropped toggle from toggle-toggle#6361
fix(menu-toggle): dropped toggle from toggle-toggle#6361mcoker merged 3 commits intopatternfly:v6from
Conversation
|
Preview: https://patternfly-pr-6361.surge.sh A11y report: https://patternfly-pr-6361-a11y.surge.sh |
There was a problem hiding this comment.
I have a few questions that look like they were part of the PR to add the small variant (#6349)
Also I noticed the padding on the small plain button and small plain menu toggle are a little different. The button uses xs left/right padding, and the menu toggle uses sm left/right padding. Should those match? @lboehling @andrew-ronaldson
|
|
||
| // * Menu toggle icon | ||
| --#{$menu-toggle}__icon--Height: calc(var(--#{$menu}__item--FontSize) * var(--#{$menu}__item--LineHeight)); | ||
| --#{$menu-toggle}__icon--MinHeight: calc(var(--#{$menu}__item--FontSize) * var(--#{$menu}__item--LineHeight)); |
There was a problem hiding this comment.
Why do we need to specify a height for this and the __toggle-icon?
| {{#if menu-toggle--HasKebab}} | ||
| {{#> menu-toggle-toggle-icon}} | ||
| {{#> menu-toggle-icon}} | ||
| <svg class="pf-v5-svg" viewBox="0 0 192 512" fill="currentColor" aria-hidden="true" role="img" width="1em" height="1em"><path d="M96 184c39.8 0 72 32.2 72 72s-32.2 72-72 72-72-32.2-72-72 32.2-72 72-72zM24 80c0 39.8 32.2 72 72 72s72-32.2 72-72S135.8 8 96 8 24 40.2 24 80zm0 352c0 39.8 32.2 72 72 72s72-32.2 72-72-32.2-72-72-72-72 32.2-72 72z"></path></svg> |
There was a problem hiding this comment.
Curious why this was changed to an SVG instead of the FA icon?
fe3a897 to
86cd879
Compare
86cd879 to
eec851d
Compare
eec851d to
a6f310e
Compare
|
🎉 This PR is included in version 6.0.0-alpha.99 🎉 The release is available on: Your semantic-release bot 📦🚀 |
followup for #6349 (comment)