fix(vars): fix invalid token names#6328
Conversation
|
Preview: https://patternfly-pr-6328.surge.sh A11y report: https://patternfly-pr-6328-a11y.surge.sh |
There was a problem hiding this comment.
Looks good. Had a comment below which could be a followup, but depends whether we'd want to add anything back in that was removed in this PR
| {{#> login-main-footer-links-item-link login-main-footer-links-item-link--attribute='aria-label="Log in with Google"'}} | ||
| <svg aria-hidden="true" xmlns="http://www.w3.org/2000/svg" viewBox="0 0 488 512"><path d="M488 261.8C488 403.3 391.1 504 248 504 110.8 504 0 393.2 0 256S110.8 8 248 8c66.8 0 123 24.5 166.3 64.9l-67.5 64.9C258.5 52.6 94.3 116.6 94.3 256c0 86.5 69.1 156.6 153.7 156.6 98.2 0 135-70.4 140.8-106.9H248v-85.3h236.1c2.3 12.7 3.9 24.9 3.9 41.4z"/></svg> | ||
| {{/login-main-footer-links-item-link}} | ||
| {{#> button button--IsPlain=true button--aria-label="Log in with Google"}} |
There was a problem hiding this comment.
Could be a followup, but with this update the icon color for the "log in with..." buttons no longer works in dark theme:
Looks like it's because we're no longer targeting the fill property for the icon color here after removing the login-main-footer-links-item-link component + styling.
There was a problem hiding this comment.
nice! I meant to add fill="currentColor" to those SVGs. updated
https://patternfly-pr-6328.surge.sh/components/login-page/html/basic/
|
🎉 This PR is included in version 6.0.0-alpha.85 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Part of #6305, but I think we should leave that issue open and do this again once core code changes are complete.