fix(menu): updates for alpha#6322
Merged
mattnolting merged 3 commits intopatternfly:v6from Feb 26, 2024
Merged
Conversation
Collaborator
|
Preview: https://patternfly-pr-6322.surge.sh A11y report: https://patternfly-pr-6322-a11y.surge.sh |
kmcfaul
reviewed
Feb 15, 2024
| padding-inline-end: var(--#{$menu}__list-item--has--menu-action--PaddingInlineEnd); | ||
| } | ||
|
|
||
| &:focus-within, |
Contributor
There was a problem hiding this comment.
I think we need pf-m-focus back for typeahead select to manually show visual focus on an item, because actual focus remains on the input. It was removed in the previous menu PR.
thatblindgeye
approved these changes
Feb 16, 2024
kmcfaul
approved these changes
Feb 19, 2024
mattnolting
requested changes
Feb 26, 2024
Collaborator
There was a problem hiding this comment.
Nice work, several version updates are needed for examples.
| @@ -560,13 +567,6 @@ | |||
| // - Menu check | |||
| .#{$menu}__item-check .#{$check} { | |||
| --pf-v5-c-check__input--TranslateY: none; | |||
Collaborator
There was a problem hiding this comment.
Suggested change
| --pf-v5-c-check__input--TranslateY: none; | |
| --pf-v6-c-check__input--TranslateY: none; |
mattnolting
approved these changes
Feb 26, 2024
Collaborator
|
🎉 This PR is included in version 6.0.0-alpha.93 🎉 The release is available on: Your semantic-release bot 📦🚀 |
8000
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #6319
I didn't fix this issue with the item hover/focus color being different between menus - I believe it has to do with the blend mode and we're going to try an alternative to the blend mode for alpha, which will hopefully resolve whatever's going on there
Also left and fixed the for/id attributes (instead of just removing them) on the labels with nested checkboxes because that matches the react component.