fix(nav): updates to horizontal subnav#6302
Conversation
|
Preview: https://patternfly-pr-6302.surge.sh A11y report: https://patternfly-pr-6302-a11y.surge.sh |
| --#{$page}__sidebar--main__main-subnav--BorderLeftWidth: var(--pf-t--global--border--width--divider--default); | ||
| --#{$page}__sidebar--m-collapsed--main__main-subnav--BorderLeftWidth: 0; | ||
|
|
||
| --#{$page}__main-subnav--BackgroundColor: var(--pf-t--global--background--color--primary--default);; |
|
Should the button have the
|
|
@tlabaj only when the button isn't a |
58e8186 to
dd448b5
Compare
| .#{$toolbar} { | ||
| --#{$toolbar}--Width: var(--#{$masthead}--#{$toolbar}--Width); | ||
| --#{$toolbar}__content--PaddingBlock: var(--#{$masthead}--#{$toolbar}--PaddingBlock); | ||
| --#{$toolbar}__content--PaddingInline: var(--#{$masthead}--#{$toolbar}--PaddingInline); | ||
| --#{$toolbar}__content--MinWidth: 0; | ||
| } |
There was a problem hiding this comment.
Aren't these going to include --pf-v5- twice - do we want that? Maybe a cut/paste or merge error?
|
One other comment - the focus rings on the scroll buttons are a bit cut off and weird, but that's definitely fine for a follow up issue. |
|
Screenshots of a nav demo with horizontal subnav with scrollbars 
|
There was a problem hiding this comment.
Looks fabulous! Love the focus 💍
|
🎉 This PR is included in version 6.0.0-alpha.99 🎉 The release is available on: Your semantic-release bot 📦🚀 |
fixes #6299