feat(calendar-month): add tokens#6297
Conversation
|
Preview: https://patternfly-pr-6297.surge.sh A11y report: https://patternfly-pr-6297-a11y.surge.sh |
There was a problem hiding this comment.
Appppppproooooooooved
There was a problem hiding this comment.
LGTM! Couple of comments, I wonder if they're worth making either now or as follow ups:
I think you can remove this? It doesn't appear to do anything:
If an item is selected and hovered, the light blue hover border is still showing
And if it's focused and hovered:
I think you can fix that by adding --#{$calendar-month}__date--hover--BorderWidth: 0; to the selected block vars
patternfly/src/patternfly/components/CalendarMonth/calendar-month.scss
Lines 176 to 184 in 90d0a48
Then it looks like this:
Hover:
Focus + hover:
The year input is cut off - can see it in the screenshots above
There was a problem hiding this comment.
Another thing that could be a followup is adding an icon to the helper text in the "Invalid" example
| // @debug $date-picker; // check your variable names located in src/patternfly/sass-utilities/component-namespaces.scss | ||
|
|
||
| .#{$date-picker} { | ||
| :root, .#{$date-picker} { |
There was a problem hiding this comment.
This could be a followup since we don't show examples with an input label like Figma seems to show ("Date of birth" above the datepicker), but we should add a var for spacing between a datepicker text label and the input itself (would also need to add an example).
|
@lboehling @andrew-ronaldson I just want to check, can you confirm I should take off the hover border for the selected date? |
There was a problem hiding this comment.
Nice!! Just one small nit on the date picker selector
|
|
||
| :root, .#{$date-picker} { | ||
| :where(:root), | ||
| .#{$date-picker} { |
There was a problem hiding this comment.
| .#{$date-picker} { | |
| :where(.#{$date-picker}) { |
There was a problem hiding this comment.
Preview doesn't look to have updated, but ran your branch locally and looks good
|
🎉 This PR is included in version 6.0.0-alpha.80 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Fixes #5734
Adds tokens
Changes the date select to a menu-toggle