8000 fix(button): update plain disabled, fix mix blend mode by mcoker · Pull Request #6256 · patternfly/patternfly · GitHub
[go: up one dir, main page]
Skip to content

fix(button): update plain disabled, fix mix blend mode#6256

Merged
mcoker merged 4 commits intopatternfly:v6from
mcoker:issue-6224
Jan 30, 2024
Merged

fix(button): update plain disabled, fix mix blend mode#6256
mcoker merged 4 commits intopatternfly:v6from
mcoker:issue-6224

Conversation

@mcoker
Copy link
Contributor
@mcoker mcoker commented Jan 29, 2024 •
edited
Loading

convenience link to button preview

fixes #6224

@patternfly-build
Copy link
Collaborator
patternfly-build commented Jan 29, 2024 •
edited
Loading

Preview: https://patternfly-pr-6256.surge.sh

A11y report: https://patternfly-pr-6256-a11y.surge.sh

@wise-king-sullyman wise-king-sullyman linked an issue Jan 30, 2024 that may be closed by this pull request
Button - update plain disabled styles #6224
Closed
@srambach
Copy link
Member
srambach commented Jan 30, 2024 •
edited
Loading

I'm seeing an icon color change on hover on the aria-disabled icon buttons https://patternfly-pr-6256.surge.sh/components/button/#aria-disabled
edit: in dark mode!

thatblindgeye
thatblindgeye reviewed Jan 30, 2024
View reviewed changes
Copy link
Contributor
@thatblindgeye thatblindgeye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Love to see it. Other than Sarah's comment above looks good, also noticing changes on hover for aria-disabeld danger link and link buttons

srambach
srambach approved these changes Jan 30, 2024
View reviewed changes
Copy link
Member
@srambach srambach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 🚨

@mcoker mcoker merged commit 241d76d into patternfly:v6 Jan 30, 2024
@patternfly-build
Copy link
Collaborator
patternfly-build commented Jan 30, 2024

🎉 This PR is included in version 6.0.0-alpha.71 🎉

The release is available on:

Your semantic-release bot 📦🚀

@wise-king-sullyman wise-king-sullyman mentioned this pull request Feb 1, 2024
Closed
@mcoker mcoker deleted the issue-6224 branch January 7, 2025 16:51
@patternfly-build patternfly-build mentioned this pull request 936A Apr 16, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@srambach srambach srambach approved these changes

@thatblindgeye thatblindgeye thatblindgeye approved these changes

@andrew-ronaldson andrew-ronaldson Awaiting requested review from andrew-ronaldson

@lboehling lboehling Awaiting requested review from lboehling

Assignees

No one assigned

Labels

released on @alpha

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Button - update plain disabled styles

4 participants

@mcoker @patternfly-build @srambach @thatblindgeye
0