Merged
Conversation
Collaborator
|
Preview: https://patternfly-pr-6217.surge.sh A11y report: https://patternfly-pr-6217-a11y.surge.sh |
andrew-ronaldson
approved these changes
Jan 11, 2024
Collaborator
There was a problem hiding this comment.
Design looks good. Thanks!
Contributor
|
I don't see a "disabled" modifier for the jump links that I see as a state in the Figma, is this something we need to add? |
kmcfaul
approved these changes
Jan 12, 2024
Contributor
There was a problem hiding this comment.
Nit below that can be a followup. Also currently the designs show a help icon button next to the label text. Right now it doesn't look like there's styling to take that into account?
|
lgtm! removed the disabled variant from figma, don't think we need it for jumplinks, but can add in later if it's requested. |
thatblindgeye
approved these changes
Jan 12, 2024
Collaborator
|
🎉 This PR is included in version 6.0.0-alpha.56 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Closed
This was referenced Nov 8, 2024
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6189