feat(SimpleFileUpload): consumed Penta tokens#6211
Merged
mcoker merged 3 commits intopatternfly:v6from Jan 12, 2024
Merged
Conversation
Collaborator
|
Preview: https://patternfly-pr-6211.surge.sh A11y report: https://patternfly-pr-6211-a11y.surge.sh |
andrew-ronaldson
approved these changes
Jan 12, 2024
Collaborator
There was a problem hiding this comment.
Happy happy joy joy!
kmcfaul
approved these changes
Jan 12, 2024
b595c1b to
c20547a
Compare
Collaborator
|
🎉 This PR is included in version 6.0.0-alpha.58 🎉 The release is available on: Your semantic-release bot 📦🚀 |
1 task
1 task
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #6209
For the "with error" example, is the intent that if a file upload has a type/size restriction, it must be placed in a Form component? Or is this example more like a demo of showing how one could place a file upload inside a form? Right now React only uses Form components for a similar "restrictive" example, but it would seem like a non-restrictive file upload could/should also be placed inside a Form for some sort of submission as well.