Conversation
|
Preview: https://patternfly-pr-6208.surge.sh A11y report: htt 10BC0 ps://patternfly-pr-6208-a11y.surge.sh |
There was a problem hiding this comment.
These look great.
I saw the beta label has this hover state. @lboehling any thoughts? 
|
@andrew-ronaldson looks like it's in a plain button, which looks to just be just for the tooltip? I created an org issue to fix that - patternfly/patternfly-org#3859 |
|
The close button focus outline just slightly overlaps the text - is that ok or do we want a little more space? The focus outline in conjunction with the label shape is a little weird overall but I understand why and don't have any better ideas. :-) |
There was a problem hiding this comment.
Other than the focus outline, which can be adjusted later if we want, looks 👌
|
🎉 This PR is included in version 6.0.0-alpha.57 🎉 The release is available on: Your semantic-release bot 📦🚀 |
fixes #6181
--
TODO - still need to add states (success, error, etc)