Merged
Conversation
Collaborator
|
Preview: https://patternfly-pr-6204.surge.sh A11y report: https://patternfly-pr-6204-a11y.surge.sh |
Contributor
There was a problem hiding this comment.
One issue I'm noticing is in dark mode the text blends in with the background for the dragged item:
andrew-ronaldson
requested changes
Jan 12, 2024
Collaborator
There was a problem hiding this comment.
Can you add a border radius of --pf-t--global--border--radius--small on the drag item and the container please.
thatblindgeye
approved these changes
Jan 12, 2024
andrew-ronaldson
approved these changes
Jan 12, 2024
Collaborator
There was a problem hiding this comment.
Totally Excellent!
Collaborator
|
🎉 This PR is included in version 6.0.0-alpha.59 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #5740
As design for penta drag and drop is still in flight (for both the current and new implementations) this PR updates the current styling to use the new tokens. A follow up may be required later if the design changes.