8000 feat(Sidebar): applied Penta tokens by thatblindgeye · Pull Request #6178 · patternfly/patternfly · GitHub
[go: up one dir, main page]

Skip to content

feat(Sidebar): applied Penta tokens#6178

Merged
mcoker merged 2 commits intopatternfly:v6from
thatblindgeye:sidebarPenta
Jan 12, 2024
Merged

feat(Sidebar): applied Penta tokens#6178
mcoker merged 2 commits intopatternfly:v6from
thatblindgeye:sidebarPenta

Conversation

@thatblindgeye
Copy link
Contributor

Work towards #5711

I removed a background color var on sidebar itself that wasn't being used at all. I can add it back and apply the background color property to pf-v5-c-sidebar if we want.

@thatblindgeye thatblindgeye requested review from a team, andrew-ronaldson, lboehling, mattnolting and mcoker and removed request for a team January 2, 2024 15:47
@thatblindgeye thatblindgeye added this to the 2024.Q1 milestone Jan 2, 2024
@patternfly-build
Copy link
Collaborator
patternfly-build commented Jan 2, 2024

Copy link
Collaborator
@andrew-ronaldson andrew-ronaldson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i noticed there is a new secondary version in this PR. Do we need to add a background here or is this an example where it appears on our secondary background grey?

@thatblindgeye
Copy link
Contributor Author

@andrew-ronaldson that one's just showing it on the secondary background grey. I can remove the example itself, mainly wanted to have it shown "side by side" to the basic/default background color.

@andrew-ronaldson
Copy link
Collaborator

@andrew-ronaldson that one's just showing it on the secondary background grey. I can remove the example itself, mainly wanted to have it shown "side by side" to the basic/default background color.

I think that's a good idea. Maybe we just add "On secondary background" to the example for clarity?

@thatblindgeye
Copy link
Contributor Author

@andrew-ronaldson updated example title

Copy link
Collaborator
@andrew-ronaldson andrew-ronaldson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved! thanks

Copy link
Collaborator
@mattnolting mattnolting left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LPTM! 🎉

Copy link
@lboehling lboehling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@mcoker mcoker merged commit 5c5ef1a into patternfly:v6 Jan 12, 2024
@patternfly-build
Copy link
Collaborator

🎉 This PR is included in version 6.0.0-alpha.58 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants

0