feat(Sidebar): applied Penta tokens#6178
Conversation
|
Preview: https://patternfly-pr-6178.surge.sh A11y report: https://patternfly-pr-6178-a11y.surge.sh |
There was a problem hiding this comment.
i noticed there is a new secondary version in this PR. Do we need to add a background here or is this an example where it appears on our secondary background grey?
|
@andrew-ronaldson that one's just showing it on the secondary background grey. I can remove the example itself, mainly wanted to have it shown "side by side" to the basic/default background color. |
I think that's a good idea. Maybe we just add "On secondary background" to the example for clarity? |
502fef4 to
b383259
Compare
|
@andrew-ronaldson updated example title |
There was a problem hiding this comment.
Approved! thanks
|
🎉 This PR is included in version 6.0.0-alpha.58 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Work towards #5711
I removed a background color var on sidebar itself that wasn't being used at all. I can add it back and apply the background color property to pf-v5-c-sidebar if we want.