8000 feat(TabContent): consumed Penta tokens by thatblindgeye · Pull Request #6161 · patternfly/patternfly · GitHub
[go: up one dir, main page]
Skip to content

feat(TabContent): consumed Penta tokens#6161

Merged
mcoker merged 2 commits intopatternfly:v6from
thatblindgeye:tabContentPenta
Dec 20, 2023
Merged

feat(TabContent): consumed Penta tokens#6161
mcoker merged 2 commits intopatternfly:v6from
thatblindgeye:tabContentPenta

Conversation

@thatblindgeye
Copy link
Contributor
@thatblindgeye thatblindgeye commented Dec 19, 2023

Work towards #5711

@thatblindgeye thatblindgeye requested review from a team, andrew-ronaldson, mcoker and srambach and removed request for a team December 19, 2023 16:49
@patternfly-build
Copy link
Collaborator
patternfly-build commented Dec 19, 2023 •
edited
Loading

Preview: https://patternfly-pr-6161.surge.sh

A11y report: https://patternfly-pr-6161-a11y.surge.sh

srambach
srambach approved these changes Dec 20, 2023
View reviewed changes
Copy link
Member
@srambach srambach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Preview is still down, but the code looks 💯

andrew-ronaldson
andrew-ronaldson approved these changes Dec 20, 2023
View reviewed changes
Copy link
Collaborator
@andrew-ronaldson andrew-ronaldson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ship it!

mcoker
mcoker approved these changes Dec 20, 2023
View reviewed changes
Copy link
Contributor
@mcoker mcoker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just to confirm - the tab content previously did not have a background color specified by default, so it would be transparent and the background would come from whatever it's placed inside of. Now the default background is our primary background color, with the secondary variation for a secondary background color.

Is that the intention, or should it just be transparent by default? @andrew-ronaldson

@mcoker
Copy link
Contributor
mcoker commented Dec 20, 2023

Verified with @andrew-ronaldson that we should just use a transparent background by default.

@mcoker mcoker merged commit b4fd771 into patternfly:v6 Dec 20, 2023
@patternfly-build
Copy link
Collaborator
patternfly-build commented Dec 20, 2023

🎉 This PR is included in version 6.0.0-alpha.42 🎉

The release is available on:

Your semantic-release bot 📦🚀

@srambach srambach mentioned this pull request Dec 22, 2023
Closed
mattnolting pushed a commit to mattnolting/patternfly that referenced this pull request Jan 2, 2024
@thatblindgeye @mattnolting
feat(TabContent): consumed Penta tokens (patternfly#6161)
a0f9897
@tlabaj tlabaj mentioned this pull request Jan 2, 2024
Closed
mattnolting pushed a commit to mattnolting/patternfly that referenced this pull request Jan 3, 2024
@thatblindgeye @mattnolting
feat(TabContent): consumed Penta tokens (patternfly#6161)
a1d6493
mattnolting pushed a commit to mattnolting/patternfly that referenced this pull request Jan 4, 2024
@thatblindgeye @mattnolting
feat(TabContent): consumed Penta tokens (patternfly#6161)
5897cf8
@patternfly-build patternfly-build mentioned this pull request Apr 16, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@srambach srambach srambach approved these changes

@andrew-ronaldson andrew-ronaldson andrew-ronaldson approved these changes

@mcoker mcoker mcoker approved these changes

Assignees

No one assigned

Labels

released on @alpha

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@thatblindgeye @patternfly-build @mcoker @srambach @andrew-ronaldson @evwilkin
0