8000 feat(Skeleton): consumed Penta tokens by thatblindgeye · Pull Request #6158 · patternfly/patternfly · GitHub
[go: up one dir, main page]

Skip to content

feat(Skeleton): consumed Penta tokens#6158

Merged
mcoker merged 2 commits intopatternfly:v6from
thatblindgeye:skeletonPenta
Dec 18, 2023
Merged

feat(Skeleton): consumed Penta tokens#6158
mcoker merged 2 commits intopatternfly:v6from
thatblindgeye:skeletonPenta

Conversation

@thatblindgeye
Copy link
Contributor

Work towards #5738

@thatblindgeye thatblindgeye changed the title feat(Skeleton): consuemd Penta tokens feat(Skeleton): consumed Penta tokens Dec 18, 2023
@thatblindgeye thatblindgeye requested review from a team, andrew-ronaldson, mattnolting and srambach and removed request for a team December 18, 2023 18:51
@patternfly-build
Copy link
Collaborator
patternfly-build commented Dec 18, 2023

Copy link
Collaborator
@andrew-ronaldson andrew-ronaldson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

--#{$skeleton}--after--LinearGradientAngle: 90deg;
--#{$skeleton}--after--LinearGradientColorStop1: var(--#{$pf-global}--palette--black-150);
--#{$skeleton}--after--LinearGradientColorStop1: var(--pf-t--global--background--color--secondary--default);
--#{$skeleton}--after--LinearGradientColorStop2: #ededed;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's use a token here... maybe --pf-t--global--color--nonstatus--gray--default ?

@thatblindgeye
Copy link
Contributor Author

@srambach

Screen.Recording.2023-12-18.at.2.31.23.PM.mov

@thatblindgeye
Copy link
Contributor Author
Screen.Recording.2023-12-18.at.2.33.30.PM.mov

Copy link
Member
@srambach srambach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fabulous! 🦴

@mcoker mcoker merged commit d244d9f into patternfly:v6 Dec 18, 2023
@patternfly-build
Copy link
Collaborator

🎉 This PR is included in version 6.0.0-alpha.41 🎉

The release is available on:

Your semantic-release bot 📦🚀

mattnolting pushed a commit to mattnolting/patternfly that referenced this pull request Dec 19, 2023
* feat(Skeleton): consuemd Penta tokens

* Updated animation duration and gradient token
mattnolting pushed a commit to mattnolting/patternfly that referenced this pull request Dec 19, 2023
* feat(Skeleton): consuemd Penta tokens

* Updated animation duration and gradient token
mattnolting pushed a commit to mattnolting/patternfly that referenced this pull request Dec 19, 2023
* feat(Skeleton): consuemd Penta tokens

* Updated animation duration and gradient token
mattnolting pushed a commit to mattnolting/patternfly that referenced this pull request Dec 19, 2023
* feat(Skeleton): consuemd Penta tokens

* Updated animation duration and gradient token
mattnolting pushed a commit to mattnolting/patternfly that referenced this pull request Dec 27, 2023
* feat(Skeleton): consuemd Penta tokens

* Updated animation duration and gradient token
mattnolting pushed a commit to mattnolting/patternfly that referenced this pull request Jan 2, 2024
* feat(Skeleton): consuemd Penta tokens

* Updated animation duration and gradient token
mattnolting pushed a commit to mattnolting/patternfly that referenced this pull request Jan 3, 2024
* feat(Skeleton): consuemd Penta tokens

* Updated animation duration and gradient token
mattnolting pushed a commit to mattnolting/patternfly that referenced this pull request Jan 4, 2024
* feat(Skeleton): consuemd Penta tokens

* Updated animation duration and gradient token
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

0