feat(Spinner): consumed Penta tokens#6154
Conversation
| --#{$spinner}--m-sm--diameter: var(--pf-t--global--icon--size--md); | ||
| --#{$spinner}--m-md--diameter: var(--pf-t--global--icon--size--lg); | ||
| --#{$spinner}--m-lg--diameter: var(--pf-t--global--icon--size--xl); | ||
| --#{$spinner}--m-xl--diameter: var(--pf-t--global--icon--size--2xl); |
There was a problem hiding this comment.
Do we still need this modifier class since this is the default size of a spinner?
There was a problem hiding this comment.
I lean to the side of leaving the modifier for completeness but I wouldn't fight about it.
There was a problem hiding this comment.
IMO the "inline" spinner should be the default, then you would opt-in to a size variation. It seems odd that the default spinner is so large.
|
Preview: https://patternfly-pr-6154.surge.sh A11y report: https://patternfly-pr-6154-a11y.surge.sh |
| --#{$spinner}--Width: var(--#{$spinner}--diameter); | ||
| --#{$spinner}--Height: var(--#{$spinner}--diameter); | ||
| --#{$spinner}--Color: var(--#{$pf-global}--primary-color--100); | ||
| --#{$spinner}--Color: var(--pf-t--global--icon--color--brand--default); |
There was a problem hiding this comment.
This seems like the right value but in figma it's defined as the border--color--brand token. cc @lboehling @andrew-ronaldson do you know which is right?
| --#{$spinner}--m-sm--diameter: var(--pf-t--global--icon--size--md); | ||
| --#{$spinner}--m-md--diameter: var(--pf-t--global--icon--size--lg); | ||
| --#{$spinner}--m-lg--diameter: var(--pf-t--global--icon--size--xl); | ||
| --#{$spinner}--m-xl--diameter: var(--pf-t--global--icon--size--2xl); |
There was a problem hiding this comment.
IMO the "inline" spinner should be the default, then you would opt-in to a size variation. It seems odd that the default spinner is so large.
|
🎉 This PR is included in version 6.0.0-alpha.44 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Work towards #5738