chore(divider): added tokens, fixed breaking change comments#6142
Merged
mcoker merged 3 commits intopatternfly:v6from Dec 13, 2023
Merged
chore(divider): added tokens, fixed breaking change comments#6142mcoker merged 3 commits intopatternfly:v6from
mcoker merged 3 commits intopatternfly:v6from
Conversation
Collaborator
|
Preview: https://patternfly-pr-6142.surge.sh A11y report: https://patternfly-pr-6142-a11y.surge.sh |
72854c1 to
643275e
Compare
srambach
reviewed
Dec 13, 2023
| height: 100%; | ||
| } | ||
|
|
||
| :root { |
Member
There was a problem hiding this comment.
I think we decided to use :root, .#{$divider} for variable scoping, correct?
Collaborator
Author
There was a problem hiding this comment.
We did, for specific components that need that support due to mixin inclusions. I don't see a need for that here, as it increases specificity, which could result in unwanted styling collisions
Collaborator
Author
There was a problem hiding this comment.
| increases specificity
@srambach limits the ability to update variables from a parent selector, rather
Contributor
There was a problem hiding this comment.
@mattnolting the plan for now is to update all the components we're working on to use both selectors, just so we don't run into issues from updating the scope, then once we're in a good spot with the updates, update them just to use :root and run the screenshot tool before/after and see what all breaks, then go from there. WDYT of that? There may be other scoping issues (other than the mixin bit we saw) we may not catch, but the screenshot tool should catch 'em all.
Closed
643275e to
79f9b5f
Compare
* feat(breaker): bump this version to 6.0 (patternfly#5800) * fix: use prerelease tag format with dry run * fix: turn off dryrun * feat(tokens): add initial global tokens (patternfly#5843) * feat(Button): adds tokens and applies to buttons (patternfly#5908) * feat(table): apply tokens from hackathon (patternfly#5965) * feat(menu-toggle): add in work from hackathon (patternfly#5931) * feat(nav): adds tokens to page and nav (patternfly#5942) * chore(tokens): update tokens from figma (patternfly#5970) * feat(page): page and masthead updates from hackathon (patternfly#5968) * fix(tokens): add dark theme blend mode token (patternfly#5992) * feat(notificationBadge): refactor with tokens (patternfly#5991) * chore(masthead ): applied tokens (patternfly#6004) * feat(alert): apply tokens (patternfly#6002) * feat(alert): apply tokens * feat(alert): remove unused background color * feat(page): apply tokens (patternfly#6021) * feat(page): apply tokens * feat(page): undo menu__list change * feat(page): tweak spacing * fix(table): fix clickable overlay (patternfly#6025) * fix(box-shadow): typo in box shadow token names (patternfly#6039) * fix(badge): adds tokens, dropdown toggle icon (patternfly#6037) * feat(hint): apply tokens (patternfly#6030) * feat(hint): apply tokens * feat(hint): fix typo * feat(hint): update spacing * feat(hint): update border radius * feat(hint): fix heading font * feat(text, title, list): apply tokens (patternfly#6031) * feat(page): remove padding on nav sidebar (patternfly#6053) * fix(tokens): adjust font-weight base for headings (patternfly#6070) * feat(login): apply tokens (patternfly#6028) * feat(modal): add tokens to modal and about modal (patternfly#6042) * fix(font): use variable font, add opt-in for legacy font (patternfly#6073) * feat(ExpandableSection): added tokens (patternfly#6063) * feat(Tooltip): applied tokens (patternfly#6064) * feat(Popover): applied tokens (patternfly#6065) * feat(BackToTop): refactor with tokens (patternfly#6085) * feat(SkipToContent): refactor with tokens (patternfly#6090) * feat(Accordion): applied tokens (patternfly#6058) * feat(banner): refactor with tokens (patternfly#6081) * feat(InlineEdit): applied tokens Took a stab at applying the tokens here. There are some items that will be fixed with icon buttons. * chore(tokens): updates tokens from figma (patternfly#6103) * chore(tokens): updating usage of new font tokens (patternfly#6111) * feat(breadcrumb): apply tokens (patternfly#6060) * feat(HelperText): apply tokens (patternfly#6118) * feat(HelperText): first tokens * feat(HelperText): tokens changes * feat(HelperText): fixes * feat(Pagination): applied tokens (patternfly#6089) * feat(Pagination): applied tokens * Removed themes directory * Removed button and menutoggle styles, added wrapper * Removed padding vars for pagination container * Updated tokens and vars for padding * fix(Pagination): updated property order * Updated var names to remove md text * feat(avatar): apply tokens (patternfly#6122) * chore(ExpandableSection): updated Penta docs and focus/hover styling (patternfly#6124) * feat(EmptyState): apply tokens (patternfly#6056) * fix(form): keep form groups/controls from growing too wide (patternfly#6109) * chore(deps): update dependency @patternfly/react-core to v5.1.2 (patternfly#6113) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update dependency @patternfly/react-code-editor to v5.1.2 (patternfly#6112) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update dependency @patternfly/react-table to v5.1.2 (patternfly#6114) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix(card/menu-toggle/check): alignment bugs (patternfly#6110) * feat(SimpleList): pull in new v6 branch (patternfly#6128) * chore: turn on dryrun until release fixed [ci skip] --------- Co-authored-by: Sarah Rambacher <srambach@redhat.com> Co-authored-by: Michael Coker <35148959+mcoker@users.noreply.github.com> Co-authored-by: Matt Nolting <matthew.nolting@gmail.com> Co-authored-by: Eric Olkowski <70952936+thatblindgeye@users.noreply.github.com> Co-authored-by: Austin Sullivan <ausulliv@redhat.com> Co-authored-by: Andrew Ronaldson <aronalds@redhat.com> Co-authored-by: kmcfaul <45077788+kmcfaul@users.noreply.github.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
79f9b5f to
1641f66
Compare
mcoker
approved these changes
Dec 13, 2023
Comment on lines
+38
to
+40
| &:is(hr) { | ||
| border: 0; // removes the default border styling on an hr | ||
| } |
Contributor
There was a problem hiding this comment.
just curious why we need to target hr and not just use this as a base style? Kinds of like how we apply border: 0 to things that can be both links and buttons.
Closed
mattnolting
added a commit
to mattnolting/patternfly
that referenced
this pull request
Dec 14, 2023
mattnolting
added a commit
to mattnolting/patternfly
that referenced
this pull request
Dec 14, 2023
mattnolting
added a commit
to mattnolting/patternfly
that referenced
this pull request
Dec 15, 2023
mattnolting
added a commit
to mattnolting/patternfly
that referenced
this pull request
Dec 15, 2023
Collaborator
|
🎉 This PR is included in version 6.0.0-alpha.39 🎉 The release is available on: Your semantic-release bot 📦🚀 |
mattnolting
added a commit
to mattnolting/patternfly
that referenced
this pull request
Dec 19, 2023
mattnolting
added a commit
to mattnolting/patternfly
that referenced
this pull request
Dec 27, 2023
mattnolting
added a commit
to mattnolting/patternfly
that referenced
this pull request
Jan 2, 2024
mattnolting
added a commit
to mattnolting/patternfly
that referenced
this pull request
Jan 3, 2024
mattnolting
added a commit
to mattnolting/patternfly
that referenced
this pull request
Jan 4, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #6136
Couple of things to note
• Added
// * {Component}to:rootvariable comments to make them searchable by{Component}or* {Component}• Added
// - {Component}to component/elements comments to make them searchable by{Component}or- {Component}• Removed unnecessary
::afterstyling and breaking change comments• Simplified implementation