8000 feat(form): tokens for form, form control, radio, check by srambach · Pull Request #6071 · patternfly/patternfly · GitHub
[go: up one dir, main page]
Skip to content

feat(form): tokens for form, form control, radio, check#6071

Closed
srambach wants to merge 4 commits intopatternfly:v6-oldfrom
srambach:5706-form-controls
Closed

feat(form): tokens for form, form control, radio, check#6071
srambach wants to merge 4 commits intopatternfly:v6-oldfrom
srambach:5706-form-controls

Conversation

@srambach
Copy link
Member
@srambach srambach commented Nov 20, 2023 •
edited
Loading

I want to get this up for design to look at - @lboehling @andrew-ronaldson
This has the change to the font-weight for bold body text to be 500.

Note:

  • Input groups and number input aren't included here
  • I'm still not sure the labels are the right font, but body text 12pt 500 weight matches figma
  • There is a crazy calculation for form group labels that I translated to tokens, but I don't think it's quite right, and in figma, the labels are just top aligned to the form control. Opinions?

@patternfly-build
Copy link
Collaborator
patternfly-build commented Nov 20, 2023 •
edited
Loading

Preview: https://patternfly-pr-6071.surge.sh

A11y report: https://patternfly-pr-6071-a11y.surge.sh

@lboehling
Copy link
lboehling commented Nov 22, 2023

thanks sarah! i'm not seeing font weight 500 come through bold at all for the form labels, it seems to match the regular weight. Also now that i'm seeing it live, i wonder if we should use the default body size for the labels. they look larger in figma 🤷‍♀️ i can update design to match if we want to bump that up. otherwise i think this looks great!!

@srambach srambach marked this pull request as ready for review November 30, 2023 22:07
@andrew-ronaldson
Copy link
Collaborator
andrew-ronaldson commented Dec 6, 2023

Thanks for this @srambach. Couple notes:
Looks like the grid-gap between check/radio and label is set to 16px. I think it should be var(--global-spacer-sm, 8px)
Also, I think these items should be aligned vertically in the middle.

@srambach
Copy link
Member Author
srambach commented Dec 6, 2023

@andrew-ronaldson Thanks - not sure what happened there. Should be fixed now.

@srambach
Copy link
Member Author
srambach commented Dec 12, 2023
8000

Closing for new v6 version

@srambach srambach closed this Dec 12, 2023
@srambach srambach mentioned this pull request Dec 12, 2023
Merged
@srambach srambach deleted the 5706-form-controls branch April 6, 2024 02:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mattnolting mattnolting Awaiting requested review from mattnolting

@mcoker mcoker Awaiting requested review from mcoker

@andrew-ronaldson andrew-ronaldson Awaiting requested review from andrew-ronaldson

@lboehling lboehling Awaiting requested review from lboehling

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@srambach @patternfly-build @lboehling @andrew-ronaldson
0