8000 Tooltip/popover - update examples/demos to use logical position classes · Issue #5886 · patternfly/patternfly · GitHub
[go: up one dir, main page]

Skip to content

Tooltip/popover - update examples/demos to use logical position classes #5886

@mcoker

Description

@mcoker

re: #5882 (review)

dependent on patternfly/patternfly-react#9632

Instead of top/right/bottom/left[-other-directions], we should update our examples to use the block/inline-start/end equivalents. However, that implies we should update the react components to either 1) use those classes instead of the existing ones, 2) accept new logical direction values for the placement prop that use the new classes, and/or 3) look into whether popper supports the logical equivalents for its positioning, it looks like the placement prop currently supports a [direction]-[logical-direction] format eg top-start or left-end (https://popper.js.org/docs/v2/constructors/#options)

cc @thatblindgeye @wise-king-sullyman

Metadata

Metadata

Assignees

No one assigned

    Labels

    wontfixThis will not be worked on

    Type

    No type

    Projects

    Status

    Done

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      0