feat(ChatbotContent): Add variant with white background#689
feat(ChatbotContent): Add variant with white background#689rebeccaalpert merged 1 commit intopatternfly:mainfrom
Conversation
|
Preview: https://chatbot-pr-chatbot-689.surge.sh A11y report: https://chatbot-pr-chatbot-689-a11y.surge.sh |
8000
f38a1d9 to
e24bbf3
Compare
There was a problem hiding this comment.
LGTM, couple questions below, but I think things are good as-is
| /** Sets background color to primary */ | ||
| isPrimary?: boolean; |
There was a problem hiding this comment.
Would we ever expect to be able to choose anything other than a boolean of "primary or not" in the future?
There was a problem hiding this comment.
My guess is we want to dissuade people from doing purple theme, etc., but only time will tell.
There was a problem hiding this comment.
future purple themes will be updating the primary and other colors so it should be okay.
The only other color variant i can imagine not being accounted for is a 'transparent' background color... but we don't have to cross that bridge yet.
| // ============================================================================ | ||
| 10000 | // Custom color variant styles | |
| // ============================================================================ | ||
| .pf-chatbot__content-m-primary { |
There was a problem hiding this comment.
WDYT about instead applying just pf-m-primary to the div container and moving this block within the .pf-chatbot__content block?
There was a problem hiding this comment.
Works for me! All set.
This was a request from OpenShift AI - they are looking for more flexibility in complex embedded layouts.
e24bbf3 to
3690368
Compare
There was a problem hiding this comment.
So nice I had to approve it twice
| /** Sets background color to primary */ | ||
| isPrimary?: boolean; |
There was a problem hiding this comment.
future purple themes will be updating the primary and other colors so it should be okay.
The only other color variant i can imagine not being accounted for is a 'transparent' background color... but we don't have to cross that bridge yet.
|
🎉 This PR is included in version 6.5.0-prerelease.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This was a request from OpenShift AI - they are looking for more flexibility in complex embedded layouts.
This was a request from OpenShift AI - they are looking for more flexibility in complex embedded layouts.
I'll add a demo with the footer piece since that's going to be a bigger PR.