chore: remove theme switcher overrides#675
Merged
rebeccaalpert merged 1 commit intopatternfly:mainfrom Sep 15, 2025
Merged
Conversation
|
Preview: https://chatbot-pr-chatbot-675.surge.sh A11y report: https://chatbot-pr-chatbot-675-a11y.surge.sh |
rebeccaalpert
approved these changes
Sep 10, 2025
Member
|
This does cause problems with our demos in ChatBot - looking to see if I can find a better selector target. |
Contributor
Author
|
@rebeccaalpert oh sorry I should have included that the org/docs-framework change needs to merge and be pulled in before this PR will look right |
Contributor
Author
|
@rebeccaalpert I tried updating the docs-framework version (just that package and also the diff below updating alll the other diff --git a/package.json b/package.json
index be6f713..0434afc 100644
--- a/package.json
+++ b/package.json
@@ -39,10 +39,10 @@
"@babel/preset-react": "^7.23.3",
"@babel/preset-typescript": "^7.23.3",
"@octokit/rest": "^18.0.0",
- "@patternfly/documentation-framework": "6.19.0",
- "@patternfly/patternfly": "^6.1.0",
- "@patternfly/react-icons": "^6.1.0",
- "@patternfly/react-table": "^6.1.0",
+ "@patternfly/documentation-framework": "6.22.6",
+ "@patternfly/patternfly": "^6.3.0",
+ "@patternfly/react-icons": "^6.3.0",
+ "@patternfly/react-table": "^6.3.0",
"@swc/core": "1.3.96",
"@testing-library/dom": "^9.3.4",
"@testing-library/jest-dom": "^6.4.2",npm error code ERESOLVE
npm error ERESOLVE unable to resolve dependency tree
npm error
npm error While resolving: @patternfly/chatbot@1.0.0
npm error Found: react@19.1.1
npm error node_modules/react
npm error peer react@"^18 || ^19" from @patternfly/chatbot@1.0.0
npm error packages/module
npm error @patternfly/chatbot@1.0.0
npm error node_modules/@patternfly/chatbot
npm error workspace packages/module from the root project
npm error peer react@"^17 || ^18 || ^19" from @patternfly/react-code-editor@6.3.1
npm error node_modules/@patternfly/react-code-editor
npm error @patternfly/react-code-editor@"^6.1.0" from @patternfly/chatbot@1.0.0
npm error packages/module
npm error @patternfly/chatbot@1.0.0
npm error node_modules/@patternfly/chatbot
npm error workspace packages/module from the root project
npm error peer @patternfly/react-code-editor@"^6.3.0" from @patternfly/documentation-framework@6.19.0
npm error node_modules/@patternfly/documentation-framework
npm error dev @patternfly/documentation-framework@"6.19.0" from @patternfly/chatbot@1.0.0
npm error packages/module
npm error @patternfly/chatbot@1.0.0
npm error node_modules/@patternfly/chatbot
npm error 3 more (react-dom, @patternfly/react-core, @patternfly/react-table)
npm error
npm error Could not resolve dependency:
npm error peer react@"^17.0.0 || ^18.0.0" from @patternfly/documentation-framework@6.19.0
npm error node_modules/@patternfly/documentation-framework
npm error dev @patternfly/documentation-framework@"6.19.0" from @patternfly/chatbot@1.0.0
npm error packages/module
npm error @patternfly/chatbot@1.0.0
npm error node_modules/@patternfly/chatbot
npm error workspace packages/module from the root project
npm error
npm error Fix the upstream dependency conflict, or retry
npm error this command with --force or --legacy-peer-deps
npm error to accept an incorrect (and potentially broken) dependency resolution.
npm error
npm error
npm error For a full report see:
npm error /Users/cmichael/.npm/_logs/2025-09-11T00_43_19_996Z-eresolve-report.txt
npm error A complete log of this run can be found in: /Users/cmichael/.npm/_logs/2025-09-11T00_43_19_996Z-debug-0.log |
c383a81 to
a253dc7
Compare
|
🎉 This PR is included in version 6.4.0-prerelease.23 🎉 The release is available on: Your semantic-release bot 📦🚀 |
rebeccaalpert
pushed a commit
to rebeccaalpert/virtual-assistant
that referenced
this pull request
Oct 24, 2025
Theme switcher was moved to the left in the main docs framework so we no longer need any ChatBot CSS for this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the theme switcher overrides that put the menu in the bottom/left. docs-framework has been updated so it's in the bottom/left by default.
Can verify this once patternfly/patternfly-org#4775 is merged.