feat(ToolCalls): added component#667
Merged
rebeccaalpert merged 6 commits intopatternfly:mainfrom Sep 9, 2025
Merged
Conversation
|
Preview: https://chatbot-pr-chatbot-667.surge.sh A11y report: https://chatbot-pr-chatbot-667-a11y.surge.sh |
rebeccaalpert
suggested changes
Sep 4, 2025
Member
There was a problem hiding this comment.
Looking good overall to me code-wise. There are mostly just some differences from what I think Kayla intended:
.pf-chatbot__tool-call-title needs an overflow adjustment (see tiny scrollbar on right):
Expandable section looks like it's bold and has too large a font size:
Loading font size/weight also seems off and I think we only want 1 loading state for both options:
.../module/patternfly-docs/content/extensions/chatbot/examples/Messages/MessageWithToolCall.tsx
Outdated
Show resolved
Hide resolved
119002b to
7c7806d
Compare
0fe134d to
1c705b4
Compare
edonehoo
suggested changes
Sep 5, 2025
Contributor
There was a problem hiding this comment.
added a little more to the example description
packages/module/patternfly-docs/content/extensions/chatbot/examples/Messages/Messages.md
Outdated
Show resolved
Hide resolved
.../module/patternfly-docs/content/extensions/chatbot/examples/Messages/MessageWithToolCall.tsx
Outdated
Show resolved
Hide resolved
1c705b4 to
e766042
Compare
edonehoo
approved these changes
Sep 8, 2025
|
🎉 This PR is included in version 6.4.0-prerelease.22 🎉 The release is available on: Your semantic-release bot 📦🚀 |
rebeccaalpert
pushed a commit
to rebeccaalpert/virtual-assistant
that referenced
this pull request
Oct 24, 2025
Co-authored-by: Eric Olkowski <git.eric@thatblindgeye.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #629
Added a prop that allows some more customization of the actions (rather than the default "cancel" and "run tool" and their respective props that allow some slight customization). Can remove that if we don't want to ship it right now.
Also are the order of the default actions correct, "Cancel" followed by "Run tool"? Just asking since our ActionList examples place a "Cancel" action at the end of the list.