8000 feat(ImagePreview): Add image preview modal by rebeccaalpert · Pull Request #665 · patternfly/chatbot · GitHub
[go: up one dir, main page]

Skip to content

feat(ImagePreview): Add image preview modal#665

Merged
rebeccaalpert merged 4 commits intopatternfly:mainfrom
rebeccaalpert:image-preview
Sep 5, 2025
Merged

feat(ImagePreview): Add image preview modal#665
rebeccaalpert merged 4 commits intopatternfly:mainfrom
rebeccaalpert:image-preview

Conversation

@rebeccaalpert
Copy link
Member
@rebeccaalpert rebeccaalpert commented Aug 29, 2025

@rebeccaalpert rebeccaalpert linked an issue Aug 29, 2025 that may be closed by this pull request
@patternfly-build
Copy link
patternfly-build commented Aug 29, 2025

@rebeccaalpert rebeccaalpert changed the title feat(ImagePreview) WIP: feat(ImagePreview) Aug 29, 2025
@rebeccaalpert rebeccaalpert force-pushed the image-preview branch 5 times, most recently from 276fd9c to 5e101af Compare September 2, 2025 18:40
@rebeccaalpert rebeccaalpert changed the title WIP: feat(ImagePreview) feat(ImagePreview): Add image preview modal Sep 2, 2025
@rebeccaalpert rebeccaalpert force-pushed the image-preview branch 2 times, most recently from ede7df6 to 2c55bdf Compare September 2, 2025 18:47
@rebeccaalpert rebeccaalpert marked this pull request as ready for review September 2, 2025 18:51
@edonehoo
Copy link
Contributor
edonehoo commented Sep 3, 2025

Found a little bug in this very specific scenario I happened to do: where you open modal > check multiple images > paginate to second image > uncheck multiple images

Screen.Recording.2025-09-03.at.10.11.33.AM.mov

Otherwise I think this PR looks good to me!

@rebeccaalpert
Copy link
Member Author

Should be fixed @edonehoo! Thanks for flagging. 🙌

@rebeccaalpert
Copy link
Member Author

Just rebasing.

Copy link
Contributor
@edonehoo edonehoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a small rephrase for the example docs, otherwise this is looking good for content!


### Image preview

For images, load a view of the file name and other information in a new modal. Return users to the main ChatBot window once they dismiss the modal.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
For images, load a view of the file name and other information in a new modal. Return users to the main ChatBot window once they dismiss the modal.
To allow users to preview images, load a modal that contains a view of the file name, file size, and the image. Users can toggle between multiple images by using pagination controls at the bottom of the modal. Return users to the main ChatBot window once they close the modal.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All set!

@rebeccaalpert rebeccaalpert merged commit 49b998a into patternfly:main Sep 5, 2025
7 checks passed
@github-actions
Copy link
github-actions bot commented Sep 5, 2025

🎉 This PR is included in version 6.4.0-prerelease.21 🎉

The release is available on:

Your semantic-release bot 📦🚀

rebeccaalpert added a commit to rebeccaalpert/virtual-assistant that referenced this pull request Oct 24, 2025
Co-authored-by: Erin Donehoo <105813956+edonehoo@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow for image attachments/file preview

5 participants

0