8000 feat(Button): add new chat button and icon by melissaing · Pull Request #626 · patternfly/chatbot · GitHub
[go: up one dir, main page]
Skip to content

feat(Button): add new chat button and icon#626

Merged
rebeccaalpert merged 1 commit intopatternfly:mainfrom
melissaing:new-chat
Jul 30, 2025
Merged

feat(Button): add new chat button and icon#626
rebeccaalpert merged 1 commit intopatternfly:mainfrom
melissaing:new-chat

Conversation

@melissaing
Copy link
Contributor
@melissaing melissaing commented Jul 25, 2025

Closes #509. Updated @patternfly/documentation-framework to 6.16.0 for icon. Buttons in the header and basic chatbot demos, when clicked, do not have functionality as of this moment. If needed, these buttons can also be added to other demos.

@patternfly-build
Copy link
patternfly-build commented Jul 25, 2025 •
edited
Loading

Preview: https://chatbot-pr-chatbot-626.surge.sh

A11y report: https://chatbot-pr-chatbot-626-a11y.surge.sh

rebeccaalpert
rebeccaalpert suggested changes Jul 28, 2025
View reviewed changes
Copy link
Member
@rebeccaalpert rebeccaalpert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR. Overall this looks good to me. There's just a few text casing things, and I left some (non-blocking) notes on a couple of nitpicky things.

For @kaylachumley - this is what it looks like in Compact mode:

Screenshot 2025-07-28 at 2 52 32 PM

@rebeccaalpert
Copy link
Member
rebeccaalpert commented Jul 28, 2025

For @kaylachumley and @edonehoo - you can see changes here: https://chatbot-pr-chatbot-626.surge.sh/patternfly-ai/chatbot/ui#header and https://chatbot-pr-chatbot-626.surge.sh/patternfly-ai/chatbot/ui#header-options.

edonehoo
edonehoo reviewed Jul 29, 2025
View reviewed changes
Copy link
Contributor
@edonehoo edonehoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a small bit of docs + echoing Rebecca's suggestion about the button capitalization, otherwise looks good!

@melissaing melissaing force-pushed the new-chat branch 2 times, most recently from b095bd1 to baf70b4 Compare July 29, 2025 19:23
rebeccaalpert
rebeccaalpert suggested changes Jul 30, 2025
View reviewed changes
Copy link
Member
@rebeccaalpert rebeccaalpert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you could just pop out the changes in the main ChatBot demo, I'm 100% happy to approve.

@melissaing melissaing requested a review from rebeccaalpert July 30, 2025 19:34
@rebeccaalpert rebeccaalpert merged commit 3a52a7e into patternfly:main Jul 30, 2025
7 checks passed
@github-actions
Copy link
github-actions bot commented Jul 30, 2025

🎉 This PR is included in version 6.4.0-prerelease.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

rebeccaalpert pushed a commit to rebeccaalpert/virtual-assistant that referenced this pull request Oct 24, 2025
@melissaing @rebeccaalpert
feat(ChatbotHeaderNewChatButton): add new chat button (patternfly#626)
c268735 
Also added icon to "New chat" button in history drawer.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kaylachumley kaylachumley kaylachumley approved these changes

+2 more reviewers

@rebeccaalpert rebeccaalpert rebeccaalpert approved these changes

@edonehoo edonehoo edonehoo approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

released on @prerelease

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add "new chat" button option for header

5 participants

@melissaing @patternfly-build @rebeccaalpert @edonehoo @kaylachumley
0