Merged
Conversation
Contributor
Author
|
I see I missed bumping the manticore service. I'll take another run at this tomorrow |
Owner
|
Thanks @jdelStrother for all the patience and prodding. I'm going to merge this in now, happy for Manticore update to be separate. Plus, I want to see if I can wrangle better pagination support for Manticore, but that'll be after the upcoming release. |
Owner
|
Also worth noting: there's still CircleCI tests that run against Rails 4.2 and Sphinx 2.2 (using Ruby 2.4 😅), because I can't install Sphinx 2.2 on GitHub's more 'modern' workers (Ubuntu 18.04). But maybe it's well and truly time to retire Rails 4.2 support! It's more the loss of testing against Sphinx 2.2.11 that I'm not thrilled about. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which version you want to support is up to you, but given ruby 2.6 is no longer supported by the ruby team, maybe it's time to drop it from CI?
The
matrix.excludeoption is getting kind of verbose - wondered if there was a shorter alternative withmatrix.includebut not sure it's possible.