8000 [Models] Enable nullable (2 of 2) by iamcarbon · Pull Request #585 · passwordless-lib/fido2-net-lib · GitHub
[go: up one dir, main page]
Skip to content

[Models] Enable nullable (2 of 2) #585

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 10, 2025
Merged

[Models] Enable nullable (2 of 2) #585

merged 1 commit into from
Jan 10, 2025

Conversation

iamcarbon
Copy link
Contributor

This PR enables nullable for the Models project and updates a few properties in the Metadata namespace to match their nullability with specs.

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 56.25000% with 7 lines in your changes missing coverage. Please review.

Project coverage is 76.04%. Comparing base (b7f1735) to head (5dd1211).

Files with missing lines Patch % Lines
Src/Fido2.Models/Metadata/BiometricStatusReport.cs 0.00% 5 Missing ⚠️
Src/Fido2.Models/CredentialCreateOptions.cs 0.00% 2 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master     #585   +/-   ##
=======================================
  Coverage   76.03%   76.04%           
=======================================
  Files         101      101           
  Lines        2600     2601    +1     
  Branches      432      432           
=======================================
+ Hits         1977     1978    +1     
  Misses        513      513           
  Partials      110      110

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

abergs
abergs approved these changes Jan 10, 2025
View reviewed changes
Copy link
Collaborator
@abergs abergs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@abergs abergs merged commit b6102f0 into passwordless-lib:master Jan 10, 2025
11 checks passed
@dependabot dependabot bot mentioned this pull request Aug 29, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@abergs abergs abergs approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@iamcarbon @codecov-commenter @abergs
0