Change List<byte[]> storedDevicePublicKeys to IReadOnlyList<byte[]>
#477
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #477 +/- ##
==========================================
+ Coverage 74.11% 74.30% +0.19%
==========================================
Files 100 100
Lines 2712 2705 -7
Branches 443 444 +1
==========================================
Hits 2010 2010
+ Misses 598 591 -7
Partials 104 104 ☔ View full report in Codecov by Sentry. |
|
Looks good to me! |
abergs
approved these changes
Jan 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following #447, this PR changes
List<byte[]> storedDevicePublicKeystoIReadOnlyList<byte[]>.There is no impact on the demo website as the stored credential contains a
List<byte[]>for the device's public keys, which is compatible withIReadOnlyList<byte[]>.fido2-net-lib/Src/Fido2.Development/StoredCredential.cs
Line 51 in 5284757