10BC0 Use DateTimeOffset by joegoldman2 · Pull Request #434 · passwordless-lib/fido2-net-lib · GitHub
[go: up one dir, main page]
Skip to content

Use DateTimeOffset #434

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 23, 2023
Merged

Use DateTimeOffset #434

merged 1 commit into from
Oct 23, 2023

Conversation

joegoldman2
Copy link
Contributor

Fixes #274

@codecov-commenter
Copy link

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (15263ca) 77.50% compared to head (34e1fb8) 77.50%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master     #434   +/-   ##
=======================================
  Coverage   77.50%   77.50%           
=======================================
  Files          98       98           
  Lines        2716     2716           
  Branches      445      445           
=======================================
  Hits         2105     2105           
  Misses        492      492           
  Partials      119      119

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@iamcarbon
Copy link
Contributor

👍

@aseigler aseigler self-requested a review October 23, 2023 14:14
aseigler
aseigler approved these changes Oct 23, 2023
View reviewed changes
Copy link
Collaborator
@aseigler aseigler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@aseigler aseigler merged commit ec12c81 into passwordless-lib:master Oct 23, 2023
@joegoldman2 joegoldman2 deleted the fix/274 branch October 23, 2023 14:32
@dependabot dependabot bot mentioned this pull request Aug 29, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aseigler aseigler aseigler approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Use DateTimeOffset

4 participants

@joegoldman2 @codecov-commenter @iamcarbon @aseigler
0