Update System.IdentityModel.Tokens.Jwt and xunit #431
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@abergs Ready for review. |
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #431 +/- ##
=======================================
Coverage 77.50% 77.50%
=======================================
Files 98 98
Lines 2716 2716
Branches 445 445
=======================================
Hits 2105 2105
Misses 492 492
Partials 119 119
☔ View full report in Codecov by Sentry. |
|
If we get this merged in, I'd like to take a look at migrating to Microsoft.IdentityModel.JsonWebTokens as well. This would require that AttestationVerifier.Verify by changed to AttestationVerifier.VerifyAsync. |
|
This looks good to me! |
aseigler
approved these changes
Oct 23, 2023
|
@abergs Let me know if there's anything left on this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the following dependencies:
And reacts to the following breaking changes:
System.IdentityModel.Tokens.Jwt v7.0.2 no longer serializes byte arrays as base64 strings. When generating tokens for testing, we need to base64 encode manually. In the main library, we only validate tokens... so we are OK.
xunit 2.5.1 has an updated analyzer that require async method calls to occur in an async context. The tests have been updated accordingly.