8000 Add CredentialPropertiesOuput (RK Support) by abergs · Pull Request #411 · passwordless-lib/fido2-net-lib · GitHub
[go: up one dir, main page]

Skip to content

Conversation

abergs
Copy link
Collaborator
@abergs abergs commented Jul 28, 2023

Browsers respond with a a object.

  • Add CredentialPropertiesOutput
  • Use .ID instead of null CredentialId

@abergs abergs requested a review from aseigler July 28, 2023 16:26
@abergs abergs added the enhancement Enhancements or general improvements label Jul 28, 2023
@geel9
Copy link
geel9 commented Aug 1, 2023

This is a breaking issue preventing deserialization of the authenticator response object when/if the extension data is present (and it is at least present on safari when an RK is created)

We have had to locally implement a hack in our backend to strip out this extension data if it is present before parsing

@abergs abergs merged commit 2718d44 into master Aug 10, 2023
@abergs abergs deleted the credprops branch August 10, 2023 14:18
@senseicz
Copy link

Thank you, especially for this one.
Would it be possible to produce beta3 package, please?

@abergs
Copy link
Collaborator Author
abergs commented Aug 10, 2023

Yeah, it's in the works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Enhancements or general improvements

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

0