Fix AuthenticationExtensionsClientInputs Example json prop name for conformance tests #404
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mance tests passing
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## master #404 +/- ##
=======================================
Coverage 74.61% 74.61%
=======================================
Files 92 92
Lines 2714 2714
Branches 453 453
=======================================
Hits 2025 2025
Misses 575 575
Partials 114 114
|
abergs
approved these changes
Jul 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
expected value:
{"example.extension.bool":true}Actual current value:
{"example.extension":true}This fixes the first test:
[Server-ServerPublicKeyCredentialCreationOptions-Req-1 Test server generating ServerPublicKeyCredentialCreationOptionsRequest](https://github.com/Applications/FIDO%20Alliance%20-%20Certification%20Conformance%20Testing%20Tools.app/Contents/Resources/app.asar/app/index.html?grep=%0A%0A%20%20%20%20%20%20%20%20Server-ServerPublicKeyCredentialCreationOptions-Req-1%0A%0A%20%20%20%20%20%20%20%20Test%20server%20generating%20ServerPublicKeyCredentialCreationOptionsRequest%0A%0A%20%20%20%20)