8000 Fixes Fido2Configuration.FullyQualifiedOrigins contains a null entry when configured from a configuration section on .NET 7 · Pull Request #360 · passwordless-lib/fido2-net-lib · GitHub
[go: up one dir, main page]
Skip to content

Fixes Fido2Configuration.FullyQualifiedOrigins contains a null entry when configured from a configuration section on .NET 7 #360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from Jan 11, 2023
Merged

Fixes Fido2Configuration.FullyQualifiedOrigins contains a null entry when configured from a configuration section on .NET 7 #360

merged 1 commit into from Jan 11, 2023

Conversation

ghost
Copy link
@ghost ghost commented Jan 1, 2023

Fixes #359

Fixes Fido2Configuration.FullyQualifiedOrigins contains a null entry …
5e903e3 
…when configured from a configuration section on .NET 7
@codecov-commenter
Copy link

Codecov Report

Merging #360 (5e903e3) into master (e3851a7) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #360   +/-   ##
=======================================
  Coverage   77.95%   77.95%           
=======================================
  Files          88       88           
  Lines        2513     2513           
  Branches      421      421           
=======================================
  Hits         1959     1959           
  Misses        439      439           
  Partials      115      115
Impacted Files Coverage Δ
Src/Fido2.Models/Fido2Configuration.cs 66.66% <ø> (ø)
Src/Fido2/AuthenticatorAssertionResponse.cs 50.84% <ø> (ø)
Src/Fido2/AuthenticatorResponse.cs 57.14% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@abergs abergs added the enhancement Enhancements or general improvements label Jan 11, 2023
@abergs
Copy link
Collaborator
abergs commented Jan 11, 2023

Thank you @ypoul, looks good!

@abergs abergs self-requested a review January 11, 2023 16:01
@abergs
Copy link
Collaborator
abergs commented Jan 11, 2023

Note for the record: This is changing the public API, but not in a breaking way so can be included without major version bump.

@abergs abergs merged commit a48d2a4 into passwordless-lib:master Jan 11, 2023
@ghost ghost deleted the fix/binding branch January 17, 2023 18:24
@dependabot dependabot bot mentioned this pull request Aug 29, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

enhancement Enhancements or general improvements

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Fido2Configuration.FullyQualifiedOrigins contains a null entry when configured from a configuration section on .NET 7

2 participants

@codecov-commenter @abergs
0