10BC0 Fix TestAppleAppAttestProd test on macOS & Linux by iamcarbon · Pull Request #347 · passwordless-lib/fido2-net-lib · GitHub
[go: up one dir, main page]

Skip to content

Conversation

iamcarbon
Copy link
Contributor

There are three failing tests on Mac/Linux right now. This fixes one of them.

@codecov-commenter
Copy link

Codecov Report

Merging #347 (15bf75b) into master (9823ec0) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #347   +/-   ##
=======================================
  Coverage   77.87%   77.87%           
=======================================
  Files          88       88           
  Lines        2495     2495           
  Branches      415      415           
=======================================
  Hits         1943     1943           
  Misses        439      439           
  Partials      113      113           
Impacted Files Coverage Δ
Src/Fido2/AttestationFormat/AppleAppAttest.cs 70.83% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Collaborator
@abergs abergs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Did you have any other thoughts @aseigler?

@aseigler aseigler merged commit 1387ff5 into passwordless-lib:master Nov 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
0