8000 Improve exception handling by iamcarbon · Pull Request #323 · passwordless-lib/fido2-net-lib · GitHub
[go: up one dir, main page]
Skip to content

Improve exception handling #323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Sep 28, 2022
Merged

Improve exception handling #323

merged 13 commits into from
Sep 28, 2022

Conversation

iamcarbon
Copy link
Contributor
@iamcarbon iamcarbon commented Sep 7, 2022 •
edited
Loading

Posting for early feedback.

  • Introduces a Fido2ErrorCode to check for specific exception cases more easily
  • Update the Cbor namespace to use file-scoped namespaces
  • Eliminates linq usage in Packed

@codecov-commenter
Copy link

Codecov Report

Merging #323 (e3a55ae) into master (0dd29c7) will increase coverage by 0.19%.
The diff coverage is 73.41%.

@@            Coverage Diff             @@
##           master     #323      +/-   ##
==========================================
+ Coverage   77.45%   77.65%   +0.19%     
==========================================
  Files          87       88       +1     
  Lines        2400     2430      +30     
  Branches      402      403       +1     
==========================================
+ Hits         1859     1887      +28     
- Misses        441      442       +1     
- Partials      100      101       +1
Impacted Files Coverage Δ
.../Fido2.Models/Exceptions/Fido2MetadataException.cs 0.00% <0.00%> (ø)
Src/Fido2/AttestationFormat/AttestationFormat.cs 88.57% <ø> (ø)
Src/Fido2/AuthenticatorResponse.cs 50.00% <0.00%> (ø)
...rc/Fido2/Metadata/ConformanceMetadataRepository.cs 89.91% <ø> (ø)
Src/Fido2/Objects/AttestedCredentialData.cs 87.27% <0.00%> (ø)
Src/Fido2/AuthenticatorAssertionResponse.cs 50.84% <6.66%> (ø)
Src/Fido2/Cbor/CborBoolean.cs 60.00% <60.00%> (ø)
Src/Fido2/Cbor/CborMap.cs 65.06% <65.38%> (ø)
Src/Fido2/Cbor/CborInteger.cs 71.42% <71.42%> (ø)
...o2.Models/Exceptions/Fido2VerificationException.cs 73.33% <73.33%> (ø)
... and 14 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@abergs abergs self-requested a review September 7, 2022 12:32
@abergs
Copy link
Collaborator
abergs commented Sep 7, 2022

I like these changes. Will review 👍

@iamcarbon
Copy link
Contributor Author
iamcarbon commented Sep 7, 2022 •
edited
Loading

@abergs @aseigler Extended a couple more error codes. This is ready for review. Will do another round of refinements if this gets merged.

abergs
abergs reviewed Sep 28, 2022
View reviewed changes
Copy link
Collaborator
@abergs abergs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed everything. Great work!

@abergs abergs merged commit 19c90bf into passwordless-lib:master Sep 28, 2022
@dependabot dependabot bot mentioned this pull request Aug 29, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@abergs abergs abergs approved these changes

@aseigler aseigler aseigler approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@iamcarbon @codecov-commenter @abergs @aseigler
0