Optimization: internally track buffer mutations #390
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
A4CC
Learn more about bidirectional Unicode characters
Adds an internal bool that tracks buffer mutations (with high probability). The pixel buffer is only written to the texture view when the flag has been set, and the flag is always cleared immediately before the upload begins. Exchanges a potentially expensive memcpy with a comparatively free branch. See: #387
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an internal bool that tracks buffer mutations (with high probability). The pixel buffer is only written to the texture view when the flag has been set, and the flag is always cleared immediately before the upload begins.
Exchanges a potentially expensive memcpy with a comparatively free branch.
@dbalsom Here is the PR promised! Give it a try on your target device and let me know if this helps, or even if it makes things worse.
See: #387