8000 TST (string dtype): change any_string_dtype fixture to use actual dtype instances by jorisvandenbossche · Pull Request #59345 · pandas-dev/pandas · GitHub
[go: up one dir, main page]
Skip to content

TST (string dtype): change any_string_dtype fixture to use actual dtype instances #59345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jul 31, 2024
Merged

TST (string dtype): change any_string_dtype fixture to use actual dtype instances #59345

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
4d875d1
TST (string dtype): change any_string_dtype fixture to use actual dty…
jorisvandenbossche Jul 29, 2024
fefcb04
avoid pyarrow import error during test collection
jorisvandenbossche Jul 30, 2024
6c7a2ca
Merge branch 'main' into string-dtype-tests-fixtures
mroeschke Jul 30, 2024
a4c9d4a
Merge remote-tracking branch 'upstream/main' into string-dtype-tests-…
jorisvandenbossche Jul 31, 2024
6c0d228
fix dtype equality in case pyarrow is not installed
jorisvandenbossche Jul 31, 2024
7c19e27
keep using mode.string_storage as default for NA variant + more xfails
jorisvandenbossche Jul 31, 2024
c68f4a4
fix test_series_string_inference_storage_definition
jorisvandenbossche Jul 31, 2024
628c6e5
remove no longer necessary xfails
jorisvandenbossche Jul 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
avoid pyarrow import error during test collection
  • Loading branch information
@jorisvandenbossche
jorisvandenbossche committed Jul 30, 2024
commit fefcb0436ceb62110de221282279efbd5364e60b
16 changes: 10 additions & 6 deletions pandas/conftest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1355,11 +1355,9 @@ def object_dtype(request):
@pytest.fixture(
params=[
np.dtype("object"),
pd.StringDtype("python"),
pytest.param(pd.StringDtype("pyarrow"), marks=td.skip_if_no("pyarrow")),
pytest.param(
pd.StringDtype("pyarrow", na_value=np.nan), marks=td.skip_if_no("pyarrow")
),
("python", pd.NA),
pytest.param(("pyarrow", pd.NA), marks=td.skip_if_no("pyarrow")),
pytest.param(("pyarrow", np.nan), marks=td.skip_if_no("pyarrow")),
],
ids=[
"string=object",
Expand All @@ -1376,7 +1374,13 @@ def any_string_dtype(request):
* 'string[pyarrow]' (NA variant)
* 'str' (NaN variant, with pyarrow)
"""
return request.param
if isinstance(request.param, np.dtype):
return request.param
else:
# need to instantiate the StringDtype here instead of in the params
# to avoid importing pyarrow during test collection
storage, na_value = request.param
return pd.StringDtype(storage, na_value)


@pytest.fixture(params=tm.DATETIME64_DTYPES)
Expand Down
Loading
0