8000 String dtype: rename the storage options and add `na_value` keyword in `StringDtype()` by jorisvandenbossche · Pull Request #59330 · pandas-dev/pandas · GitHub
[go: up one dir, main page]
Skip to content

String dtype: rename the storage options and add na_value keyword in StringDtype() #59330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
Jul 29, 2024
+176 −110
Merged

String dtype: rename the storage options and add na_value keyword in StringDtype() #59330

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
2f1bc37
rename storage option and add na_value keyword
jorisvandenbossche May 20, 2024
ff95a83
Merge remote-tracking branch 'upstream/main' into string-dtype-naming
jorisvandenbossche Jul 26, 2024
10c14fb
Merge remote-tracking branch 'upstream/main' into string-dtype-naming
jorisvandenbossche Jul 26, 2024
e29ca8d
update init
jorisvandenbossche Jul 26, 2024
cb7410f
fix propagating na_value to Array class + fix some tests
jorisvandenbossche Jul 27, 2024
ffa7ead
fix more tests
jorisvandenbossche Jul 27, 2024
a9c466b
disallow pyarrow_numpy as option + fix more cases of checking storage…
jorisvandenbossche Jul 27, 2024
1fc2113
restore pyarrow_numpy as option for now
jorisvandenbossche Jul 27, 2024
b347b94
linting
jorisvandenbossche Jul 27, 2024
80489fe
try fix typing
jorisvandenbossche Jul 29, 2024
8587297
try fix typing
jorisvandenbossche Jul 29, 2024
a9650bb
fix dtype equality to take into account the NaN vs NA
jorisvandenbossche Jul 29, 2024
4136c9e
fix pickling of dtype
jorisvandenbossche Jul 29, 2024
c33e14a fix test_convert_dtypes
jorisvandenbossche Jul 29, 2024
151e3d1
update expected result for dtype='string'
jorisvandenbossche Jul 29, 2024
899e3fc
suppress typing error with _metadata attribute
jorisvandenbossche Jul 29, 2024
fc952e0
Merge remote-tracking branch 'upstream/main' into string-dtype-naming
jorisvandenbossche Jul 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
restore pyarrow_numpy as option for now
  • Loading branch information
@jorisvandenbossche
jorisvandenbossche committed Jul 27, 2024
commit 1fc2113e9627b96a447c4cc6265a65dc8acf221b
2 changes: 1 addition & 1 deletion pandas/core/config_init.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -460,7 +460,7 @@ def is_terminal() -> bool:
"string_storage",
"python",
string_storage_doc,
validator=is_one_of_factory(["python", "pyarrow"]),
validator=is_one_of_factory(["python", "pyarrow", "pyarrow_numpy"]),
)


Expand Down
6 changes: 0 additions & 6 deletions pandas/tests/arrays/string_/test_string.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -501,10 +501,6 @@ def test_arrow_roundtrip(dtype, string_storage2, request, using_infer_string):
reason="infer_string takes precedence over string storage"
)
)
if string_storage2 == "pyarrow_numpy":
# we cannot set "pyarrow_numpy" as storage option anymore, need to
# update the tests for this
request.applymarker(pytest.mark.xfail(reason="TODO(infer_string)"))

data = pd.array(["a", "b", None], dtype=dtype)
df = pd.DataFrame({"a": data})
Expand Down Expand Up @@ -535,8 +531,6 @@ def test_arrow_load_from_zero_chunks(
reason="infer_string takes precedence over string storage"
)
)
if string_storage2 == "pyarrow_numpy":
request.applymarker(pytest.mark.xfail(reason="TODO(infer_string)"))

data = pd.array([], dtype=dtype)
df = pd.DataFrame({"a": data})
Expand Down
Loading
0