8000 TST: Added script to enforce usage of match argument for tm.assert_produces_warning by chaarvii · Pull Request #59173 · pandas-dev/pandas · GitHub
[go: up one dir, main page]
Skip to content

TST: Added script to enforce usage of match argument for tm.assert_produces_warning #59173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 15 commits into from
Closed

TST: Added script to enforce usage of match argument for tm.assert_produces_warning #59173

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
7f027ac
fix ruff errors
chaarvii Jul 2, 2024
bc1bf8c
Merge remote-tracking branch 'upstream/main' into enforce-match
chaarvii Jul 2, 2024
d74e92e
update comments
chaarvii Jul 2, 2024
2562c79
fix typo
chaarvii Jul 2, 2024
c6cdc2d
exclude tm.assert_produces_warning(False)
chaarvii Jul 3, 2024
fde9825
update exclude list
chaarvii Jul 3, 2024
a5ea822
Merge remote-tracking branch 'upstream/main' into enforce-match
chaarvii Jul 3, 2024
7c4caf2
update comments
chaarvii Jul 3, 2024
cdd6303
Update scripts/enforce_match_arg_in_assert_produces_warning.py
chaarvii Jul 4, 2024
1bfe27e
as per reviews
chaarvii Jul 4, 2024
9a2313d
Merge branch 'enforce-match' of https://github.com/chaarvii/pandas in…
chaarvii Jul 4, 2024
b745226
trigger pre-commit
chaarvii Jul 4, 2024
87dd8c3
uncommit suggestion
chaarvii Jul 4, 2024
b700b71
fix sequence import
chaarvii Jul 5, 2024
75a181b
Merge branch 'main' into enforce-match
chaarvii Jul 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
as per reviews
  • Loading branch information
@chaarvii
chaarvii committed Jul 4, 2024
commit 1bfe27ec55ee1ba80cfa3df6cf3aed50f2314759
10 changes: 6 additions & 4 deletions scripts/enforce_match_arg_in_assert_produces_warning.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
"""

Enforce that all usages of tm.assert_produces_warning use
the "match" argument. This will help ensure that users always see
the correct warning message.
Expand All @@ -8,6 +7,9 @@
and tm.assert_produces_warning(False) are excluded as no warning is
produced.

This is meant to be run as a pre-commit hook - to run it manually, you can do:

pre-commit run enforce-match-arg-in-assert-produces-warning --all-files
"""


Expand Down Expand Up @@ -68,14 +70,14 @@ def main(argv: Sequence[str] | None = None) -> None:
parser.add_argument("paths", nargs="*")

args = parser.parse_args(argv)
isMatchMissing = False
is_match_missing = False

for filename in args.paths:
with open(filename, encoding="utf-8") as fd:
content = fd.read()
isMatchMissing = check_for_match_arg(content, filename) | isMatchMissing
is 4F55 _match_missing = check_for_match_arg(content, filename) | is_match_missing

if isMatchMissing:
if is_match_missing:
sys.exit(1)


Expand Down
0