8000 BUG: Interchange object data buffer has the wrong dtype / from_dataframe incorrect by MarcoGorelli · Pull Request #55227 · pandas-dev/pandas · GitHub
[go: up one dir, main page]
Skip to content

BUG: Interchange object data buffer has the wrong dtype / from_dataframe incorrect #55227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Nov 7, 2023
Merged

BUG: Interchange object data buffer has the wrong dtype / from_dataframe incorrect #55227

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
9876c64
use buffer dtype in interchange from_dataframe
MarcoGorelli Sep 21, 2023
0b936b3
Merge remote-tracking branch 'upstream/main' into use-buffer-dtype-in…
MarcoGorelli Oct 7, 2023
00ad9c7
wip
MarcoGorelli Oct 7, 2023
d54f950
wip
MarcoGorelli Oct 7, 2023
adeceb9
add failing test
MarcoGorelli Oct 7, 2023
3557b4a
wip
MarcoGorelli Oct 10, 2023
975c87c
Merge remote-tracking branch 'upstream/main' into use-buffer-dtype-in…
MarcoGorelli Oct 10, 2023
0ef179a
simplify
MarcoGorelli Oct 10, 2023
df996ac
remove unnecessary assertion
MarcoGorelli Oct 10, 2023
0bea19b
dont double-extract bit width
MarcoGorelli Oct 10, 2023
d04ac92
Update pandas/core/interchange/from_dataframe.py
MarcoGorelli Oct 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
dont double-extract bit width
  • Loading branch information
@MarcoGorelli
MarcoGorelli committed Oct 10, 2023
commit 0bea19bb37420ebac63dadc6ef2da6ed1873316b
4 changes: 2 additions & 2 deletions pandas/core/interchange/from_dataframe.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -376,15 +376,15 @@ def datetime_column_to_ndarray(col: Column) -> tuple[np.ndarray | pd.Series, Any
"""
buffers = col.get_buffers()

_, _, format_str, _ = col.dtype
_, col_bit_width, format_str, _ = col.dtype
dbuf, _ = buffers["data"]
# Consider dtype being `uint` to get number of units passed since the 01.01.1970

data = buffer_to_ndarray(
dbuf,
(
DtypeKind.INT,
col.dtype[1],
col_bit_width,
getattr(ArrowCTypes, f"INT{col.dtype[1]}"),
Endianness.NATIVE,
),
Expand Down
0