10000 TYP: simple return types by twoertwein · Pull Request #54786 · pandas-dev/pandas · GitHub
[go: up one dir, main page]
Skip to content

TYP: simple return types #54786

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Aug 31, 2023
Merged

TYP: simple return types #54786

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
6bf9293
Return None
twoertwein Aug 26, 2023
f1fb1ea
Return simple types
twoertwein Aug 27, 2023
f64da4b
ruff false positive
twoertwein Aug 28, 2023
54c05c4
isort+mypy
twoertwein Aug 28, 2023
d23a54b
typo, use " for cast
twoertwein Aug 28, 2023
eeddfa8
SingleArrayManager.dtype can also be a numpy dtype
twoertwein Aug 28, 2023
3213488
comments + test assert on CI
twoertwein Aug 29, 2023
bdb2d07
wider return types at the cost of one fewer mypy ignore
twoertwein Aug 29, 2023
4c7baf6
Merge remote-tracking branch 'upstream/main' into type
twoertwein Aug 29, 2023
5139ed3
DatetimeArray reaches IntervalArray._combined
twoertwein Aug 30, 2023
1a82367
avoid some ignores
twoertwein Aug 30, 2023
954b275
remove assert False
twoertwein Aug 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
typo, use " for cast
  • Loading branch information
@twoertwein
twoertwein committed Aug 28, 2023
commit d23a54bbffb0df66633dd8d1cd06062b22d7ca5b
3 changes: 1 addition & 2 deletions pandas/core/groupby/groupby.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,8 +143,7 @@ class providing the base-class of operations.
if TYPE_CHECKING:
from typing import Any

from padnas.core.resample import Resampler

from pandas.core.resample import Resampler
from pandas.cor 8000 e.window import (
ExpandingGroupby,
ExponentialMovingWindowGroupby,
Expand Down
4 changes: 2 additions & 2 deletions pandas/core/indexes/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,9 +196,9 @@
from pandas import (
CategoricalIndex,
DataFrame,
MultiIndex,
Series,
)
from pandas import MultiIndex # noqa: TCH004
from pandas.core.arrays import PeriodArray

__all__ = ["Index"]
Expand Down Expand Up @@ -5017,7 +5017,7 @@ def _wrap_joined_index(
# expected "Self")
mask = lidx == -1
join_idx = self.take(lidx)
right = cast(MultiIndex, other.take(ridx))
right = cast("MultiIndex", other.take(ridx))
join_index = join_idx.putmask(mask, right)._sort_levels_monotonic()
return join_index.set_names(name) # type: ignore[return-value]
else:
Expand Down
0