8000 CI: Test Python 3.12 by lithomas1 · Pull Request #53743 · pandas-dev/pandas · GitHub
[go: up one dir, main page]
Skip to content

CI: Test Python 3.12 #53743

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 29 commits into from
Jul 25, 2023
Merged

CI: Test Python 3.12 #53743

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
29 commits
Select commit Hold shift + click to select a range
ff98491
CI: Test Python 3.12
lithomas1 Jun 20, 2023
fcbe1ed
Update unit-tests.yml
lithomas1 Jun 20, 2023
dd4a488
Update config.yml
lithomas1 Jun 20, 2023
c809bcd
update
lithomas1 Jun 20, 2023
cf7e272
Merge branch 'main' into test-py312
lithomas1 Jun 20, 2023
8c7aea2
fix condition
lithomas1 Jun 20, 2023
dc88fa8
Merge branch 'main' of https://github.com/pandas-dev/pandas into test…
lithomas1 Jun 25, 2023
d2b3868
fix some tests
lithomas1 Jun 25, 2023
5814bcc
Remove wheel building for Python 3.12
lithomas1 Jun 25, 2023
7be7ea9
fix more
lithomas1 Jun 26, 2023
e9c0ed4
Use timezone.utc
mroeschke Jun 29, 2023
f735b8c
Merge remote-tracking branch 'upstream/main' into test-py312
mroeschke Jun 29, 2023
80d31e1
Merge branch 'main' into test-py312
mroeschke Jul 7, 2023
b8f351d
Address typing, utcfromtimestamp
mroeschke Jul 7, 2023
7c 8000 bfd7c
fix some slice changes
lithomas1 Jul 12, 2023
e507d45
fix all indexing bugs?
lithomas1 Jul 14, 2023
90dbdeb
fix import
lithomas1 Jul 14, 2023
5e421f3
go for green
lithomas1 Jul 14, 2023
0e04fd2
disable macos for now, fix other tests
lithomas1 Jul 14, 2023
b5ae510
Update indexing.py
lithomas1 Jul 14, 2023
b1182ac
finally fix?
lithomas1 Jul 14, 2023
ddae8f8
Merge branch 'main' into test-py312
lithomas1 Jul 14, 2023
64e12a9
Update expr.py
lithomas1 Jul 17, 2023
bc64b47
Merge branch 'main' into test-py312
lithomas1 Jul 24, 2023
2c1755e
Update pandas/tests/computation/test_eval.py
lithomas1 Jul 24, 2023
5dfc14b
Update test_eval.py
lithomas1 Jul 25, 2023
a1bd210
Update test_eval.py
lithomas1 Jul 25, 2023
298f31b
fixes
lithomas1 Jul 25, 2023
88a0cb8
formatting
lithomas1 Jul 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
disable macos for now, fix other tests
  • Loading branch information
@lithomas1
lithomas1 authored Jul 14, 2023
commit 0e04fd2230af44523149595434efa8126565bd05
6 changes: 5 additions & 1 deletion .github/workflows/unit-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -315,7 +315,11 @@ jobs:
strategy:
fail-fast: false
matrix:
os: [ubuntu-22.04, macOS-latest, windows-latest]
# TODO: Disable macOS for now, Github Actions bug where python is not
# symlinked correctly to 3.12
# xref https://github.com/actions/setup-python/issues/701
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the linked issue is now closed; can this be reenabled?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Matt enabled this again a while back, I think.

#os: [ubuntu-22.04, macOS-latest, windows-latest]
os: [ubuntu-22.04, windows-latest]

timeout-minutes: 180

Expand Down
10 changes: 2 additions & 8 deletions pandas/core/indexing.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1068,9 +1068,7 @@ def _getitem_nested_tuple(self, tup: tuple):
def _contains_slice(x: object) -> bool:
# Check if object is a slice or a tuple containing a slice
if isinstance(x, tuple):
for v in x:
if isinstance(v, slice):
return True
return any(isinstance(v, slice) for v in key)
elif isinstance(x, slice):
return True
return False
Expand Down Expand Up @@ -1439,11 +1437,7 @@ def _convert_to_indexer(self, key, axis: AxisInt):

# Slices are not valid keys passed in by the user,
# even though they are hashable in Python 3.12
contains_slice = False
if isinstance(key, tuple):
for v in key:
if isinstance(v, slice):
contains_slice = True
contains_slice = any(isinstance(v, slice) for v in key)

if is_scalar(key) or (
isinstance(labels, MultiIndex) and is_hashable(key) and not contains_slice
Expand Down
2 changes: 1 addition & 1 deletion pandas/tests/io/parser/test_parse_dates.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -717,7 +717,7 @@ def test_date_parser_int_bug(all_parsers):
StringIO(data),
index_col=0,
parse_dates=[0],
date_parser=lambda x: datetime.fromtimestamp(int(x)),
date_parser=lambda x: datetime.fromtimestamp(int(x), tz=timezone.utc),
)
expected = DataFrame(
[
Expand Down
0