CI: Build wheel from sdist #53087

lithomas1 · 2023-05-14T01:44:42Z

Have you checked that this puts the DLLs in the same place?

Last time I checked(a couple years back), it made a weird folder structure.

Have you checked that this puts the DLLs in the same place?

Sorry I'm not really sure how to check this. I just assumed since the tests passed on windowsservercore the DLLs were correctly available. What's bad about a "weird" folder structure?

I went and downloaded the wheel (not on a Windows computer, don't have access to that anymore, unfortunately).

It looks like they put DLLS into a separate folder from the window extension module, and then mess around with the DLL search path in init.py to make it work correctly (what I meant by weird, not necessarily bad, though).

See screenshots

Can you comment out the wheel repair step on Windows and make sure the wheel build fails with a missing DLL import error just as a sanity check that that works?

Just got back to this. I commented out the wheel repair step in 53c03b7 and it raises

Traceback (most recent call last): File "<string>", line 1, in <module> File "C:\Python\lib\site-packages\pandas\__init__.py", line 46, in <module> from pandas.core.api import ( File "C:\Python\lib\site-packages\pandas\core\api.py", line 47, in <module> from pandas.core.groupby import ( File "C:\Python\lib\site-packages\pandas\core\groupby\__init__.py", line 1, in <module> from pandas.core.groupby.generic import ( File "C:\Python\lib\site-packages\pandas\core\groupby\generic.py", line 69, in <module> from pandas.core.frame import DataFrame File "C:\Python\lib\site-packages\pandas\core\frame.py", line 141, in <module> from pandas.core.generic import ( File "C:\Python\lib\site-packages\pandas\core\generic.py", line 181, in <module> from pandas.core.window import ( File "C:\Python\lib\site-packages\pandas\core\window\__init__.py", line 1, in <module> from pandas.core.window.ewm import ( File "C:\Python\lib\site-packages\pandas\core\window\ewm.py", line 11, in <module> import pandas._libs.window.aggregations as window_aggregations ImportError: DLL load failed while importing aggregations: The specified module could not be found.

-Original file line number
+Diff line change
@@ Expand Up / @@ -159,7 +159,7 @@ test-skip = "*_arm64" @@
     [tool.cibuildwheel.windows]
     before-build = "pip install delvewheel"
-    #repair-wheel-command = "delvewheel repair -w {dest_dir} {wheel}"
+    repair-wheel-command = "delvewheel repair -w {dest_dir} {wheel}"
     [[tool.cibuildwheel.overrides]]
     select = "*-musllinux*"
@@ Expand Down @@

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

CI: Build wheel from sdist #53087

Uh oh!

Diff view

Diff view

Uh oh!

There are no files selected for viewing

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

CI: Build wheel from sdist #53087

Uh oh!

CI: Build wheel from sdist #53087

Uh oh!

Uh oh!

Diff view

Diff view

Uh oh!

There are no files selected for viewing

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!