8000 BUG: Fix agg ingore arg/kwargs when given list like func by luke396 · Pull Request #50863 · pandas-dev/pandas · GitHub
[go: up one dir, main page]
Skip to content

BUG: Fix agg ingore arg/kwargs when given list like func #50863

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rhshadrach merged 25 commits into from
Feb 12, 2023
Merged

BUG: Fix agg ingore arg/kwargs when given list like func #50863

Changes from 1 commit
Commits
Show all changes
25 commits
Select commit Hold shift + click to select a range
86f1fd2
BUG: Fix agg ingore arg/kwargs when given list like func
Jan 19, 2023
0ceb01d
Merge branch 'main' into fix-agg-ingore-arg-given-list-like-func
luke396 Jan 19, 2023
b0d23a0
Fix test
Jan 20, 2023
76a675c
Fix mypy
Jan 20, 2023
d1a4d17
Merge branch 'main' into fix-agg-ingore-arg-given-list-like-func
luke396 Jan 28, 2023
abe58c8
More appreciate way
Jan 29, 2023
5ce782a
Delete blank line
Jan 29, 2023
c1e48b7
Fix test failure
Jan 29, 2023
18c4f9e
Merge branch 'main' into fix-agg-ingore-arg-given-list-like-func
luke396 Jan 29, 2023
0daad25
Fix test failure
Jan 29, 2023
eab348c
Easy version
Feb 1, 2023 8000
54d27e1
Add blank lines
Feb 1, 2023
0a3d2ea
Merge branch 'main' into fix-agg-ingore-arg-given-list-like-func
luke396 Feb 1, 2023
b98b35e
Avoid incroeect axis
Feb 2, 2023
55f1376
Merge branch 'main' into fix-agg-ingore-arg-given-list-like-func
luke396 Feb 2, 2023
234cff6
Add whatsnew 2.0.0
Feb 3, 2023
6957a7c
Add blank line
Feb 3, 2023
a3ef451
More appreciate
Feb 3, 2023
1d46712
Delete blank line
Feb 3, 2023
6f28f2f
Whether Series or DataFrame
Feb 6, 2023
b4056ac
Fix test
Feb 7, 2023
279139c
Merge branch 'main' into fix-agg-ingore-arg-given-list-like-func
luke396 Feb 7, 2023
7eb2c94
Fix Groupby and add tests
Feb 9, 2023
d85ec33
Merge branch 'main' into fix-agg-ingore-arg-given-list-like-func
luke396 Feb 9, 2023
371c068
Rename variables and split bugfix
Feb 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix test failure
  • Loading branch information
luke committed Jan 29, 2023
commit 0daad25ec756ad8a3034b1d5d9e93d2b036a80e5
6 changes: 2 additions & 4 deletions pandas/core/apply.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -340,9 +340,7 @@ def agg_list_like(self) -> DataFrame | Series:
args_pass, kwargs_pass, args_remain, kwargs_remain = _map_args(
a, args_remain, kwargs_remain
)
new_res = colg.aggregate(
a, self.axis, *args_pass, **kwargs_pass
)
new_res = colg.aggregate(a, *args_pass, **kwargs_pass)
else:
new_res = colg.aggregate(a)
results.append(new_res)
Expand All @@ -356,7 +354,7 @@ def agg_list_like(self) -> DataFrame | Series:
indices = []
for index, col in enumerate(selected_obj):
colg = obj._gotitem(col, ndim=1, subset=selected_obj.iloc[:, index])
new_res = colg.aggregate(arg, self.axis, *self.args, **self.kwargs)
new_res = colg.aggregate(arg, *self.args, **self.kwargs)
results.append(new_res)
indices.append(index)
keys = selected_obj.columns.take(indices)
Expand Down
0