TYP: misc return type annotations #47558
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
reviewed
Jul 1, 2022
pandas/_testing/asserters.py
Outdated
| @@ -455,7 +455,7 @@ def repr_class(x): | |||
| raise_assert_detail(obj, msg, repr_class(left), repr_class(right)) | |||
|
|
|||
|
|
|||
| def assert_attr_equal(attr: str, left, right, obj: str = "Attributes"): | |||
| def assert_attr_equal(attr: str, left, right, obj: str = "Attributes") -> bool: | |||
There was a problem hiding this comment.
We had an issue about this previously (can't find it immediately), but all these assert_* functions should -> None. Since this function isn't publicly documented, happy to just have this refactored to not return bools
There was a problem hiding this comment.
test_assert_attr_equal_different_nulls uses assert tm.assert_attr_equal("na_value", obj, obj2) but I think this is the only function using the return value
|
Looks like the rebase with main is a little off |
I fixed it and forced pushed |
|
thanks @twoertwein |
yehoshuadimarsky
pushed a commit
to yehoshuadimarsky/pandas
that referenced
this pull request
Jul 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After this most of the low hanging return annotations that
pyright --createstub pandasfinds are in pandas/core (there are still plenty of more tricky return annotations).xref #47521