8000 DEPS/TST: tzdata is optional, not required by lithomas1 · Pull Request #47467 · pandas-dev/pandas · GitHub
[go: up one dir, main page]
Skip to content

DEPS/TST: tzdata is optional, not required #47467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
Aug 12, 2022
Merged

DEPS/TST: tzdata is optional, not required #47467

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
2939c10
DEPS/TST: tzdata is optional, not required
lithomas1 Jun 22, 2022
d4642a9
Fix name & formatting
lithomas1 Jun 22, 2022
9a75b85
another one
lithomas1 Jun 22, 2022
e112474
Merge branch 'main' into fix-tzdata-checking
lithomas1 Jun 23, 2022
371e7fb
Merge branch 'pandas-dev:main' into fix-tzdata-checking
lithomas1 Jun 29, 2022
bfff268
Update pandas/conftest.py
lithomas1 Jul 29, 2022
3c94243
make tzdata an optional dependency
lithomas1 Jul 29, 2022
7e48282
Merge branch 'fix-tzdata-checking' of github-other.com:lithomas1/pand…
lithomas1 Jul 29, 2022
eba2fb9
update
lithomas1 Aug 3, 2022
6d7c577
Merge branch 'main' into fix-tzdata-checking
lithomas1 Aug 3, 2022
19df15c
fix env files
lithomas1 Aug 3, 2022
19438d2
Merge branch 'fix-tzdata-checking' of github-other.com:lithomas1/pand…
lithomas1 Aug 3, 2022
f36bbe6
fix typing
lithomas1 Aug 5, 2022
5917870
Merge branch 'main' into fix-tzdata-checking
lithomas1 Aug 5, 2022
093ca1d
fix formatting
lithomas1 Aug 5, 2022
64de406
Update tzdata note
lithomas1 Aug 9, 2022
9a973f0
code checks
lithomas1 Aug 9, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix env files
  • Loading branch information
@lithomas1
lithomas1 committed Aug 3, 2022
commit 19df15c517e53db39f2920787169cd9b67ec83c0
2 changes: 1 addition & 1 deletion ci/deps/actions-310.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ dependencies:
- scipy
- sqlalchemy
- tabulate
- tzdata>=2022.1
- tzdata>=2022a
- xarray
- xlrd
- xlsxwriter
Expand Down
2 changes: 1 addition & 1 deletion ci/deps/actions-38-minimum_versions.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ dependencies:
- scipy=1.7.1
- sqlalchemy=1.4.16
- tabulate=0.8.9
- tzdata=2022.1
- tzdata=2022a
- xarray=0.19.0
- xlrd=2.0.1
- xlsxwriter=1.4.3
Expand Down
2 changes: 1 addition & 1 deletion ci/deps/actions-39.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ dependencies:
- scipy
- sqlalchemy
- tabulate
- tzdata>=2022.1
- tzdata>=2022a
- xarray
- xlrd
- xlsxwriter
Expand Down
5 changes: 5 additions & 0 deletions scripts/validate_min_versions_in_sync.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@
pathlib.Path("ci/deps").absolute().glob("actions-*-minimum_versions.yaml")
)
CODE_PATH = pathlib.Path("pandas/compat/_optional.py").resolve()
EXCLUDE_DEPS = {"tzdata"}
# pandas package is not available
# in pre-commit environment
sys.path.append("pandas/compat")
Expand All @@ -34,6 +35,8 @@
def get_versions_from_code() -> dict[str, str]:
install_map = _optional.INSTALL_MAPPING
versions = _optional.VERSIONS
for item in EXCLUDE_DEPS:
versions.pop(item)
return {
install_map.get(k, k).casefold(): v
for k, v in versions.items()
Expand All @@ -55,6 +58,8 @@ def get_versions_from_ci(content: list[str]) -> tuple[dict[str, str], dict[str,
elif seen_required and line.strip():
package, version = line.strip().split("=")
package = package[2:]
if package in EXCLUDE_DEPS:
continue
if not seen_optional:
required_deps[package] = version
else:
Expand Down
0